Commit cf572b13 authored by René Nussbaumer's avatar René Nussbaumer
Browse files

LUClusterSetParams: When ipolicy is updated warn for new violations

We need to loop over all node groups to apply their modification to make
sure that the new ipolicy actually affects their instance
Signed-off-by: default avatarRené Nussbaumer <>
Reviewed-by: default avatarGuido Trotter <>
Reviewed-by: default avatarMichael Hanselmann <>
parent 68ab64cf
......@@ -3789,8 +3789,14 @@ class LUClusterSetParams(LogicalUnit):
# all nodes to be modified.
self.needed_locks = {
locking.LEVEL_NODE: locking.ALL_SET,
locking.LEVEL_INSTANCE: locking.ALL_SET,
locking.LEVEL_NODEGROUP: locking.ALL_SET,
self.share_locks = {
locking.LEVEL_NODE: 1,
locking.LEVEL_INSTANCE: 1,
self.share_locks[locking.LEVEL_NODE] = 1
def BuildHooksEnv(self):
"""Build hooks env.
......@@ -3897,6 +3903,24 @@ class LUClusterSetParams(LogicalUnit):
self.new_ipolicy = _GetUpdatedIPolicy(cluster.ipolicy, self.op.ipolicy,
all_instances = self.cfg.GetAllInstancesInfo().values()
violations = set()
for group in self.cfg.GetAllNodeGroupsInfo().values():
instances = frozenset([inst for inst in all_instances
if compat.any(node in group.members
for node in inst.all_nodes)])
new_ipolicy = objects.FillIPolicy(self.new_ipolicy, group.ipolicy)
new = _ComputeNewInstanceViolations(_CalculateGroupIPolicy(cluster,
new_ipolicy, instances)
if new:
if violations:
self.LogWarning("After the ipolicy change the following instances"
" violate them: %s",
if self.op.nicparams:
utils.ForceDictType(self.op.nicparams, constants.NICS_PARAMETER_TYPES)
self.new_nicparams = cluster.SimpleFillNIC(self.op.nicparams)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment