Commit cc19798f authored by Michael Hanselmann's avatar Michael Hanselmann
Browse files

LUNodeSetParams: Lock affected instances only

Until now LUNodeSetParams would lock all instances if a node's
secondary IP address was to be changed and would then release
all instances it didn't actually need. With this patch the LU
optimistically locks instances and, once it got the locks,
checks whether they're still correct. This is similar to how
node group locking is done.
Signed-off-by: default avatarMichael Hanselmann <>
Reviewed-by: default avatarIustin Pop <>
parent 212a7fcd
......@@ -5246,6 +5246,13 @@ class LUNodeSetParams(LogicalUnit):
self.lock_all = self.op.auto_promote and self.might_demote
self.lock_instances = self.op.secondary_ip is not None
def _InstanceFilter(self, instance):
"""Filter for getting affected instances.
return (instance.disk_template in constants.DTS_INT_MIRROR and
self.op.node_name in instance.all_nodes)
def ExpandNames(self):
if self.lock_all:
self.needed_locks = {locking.LEVEL_NODE: locking.ALL_SET}
......@@ -5253,28 +5260,8 @@ class LUNodeSetParams(LogicalUnit):
self.needed_locks = {locking.LEVEL_NODE: self.op.node_name}
if self.lock_instances:
self.needed_locks[locking.LEVEL_INSTANCE] = locking.ALL_SET
def DeclareLocks(self, level):
# If we have locked all instances, before waiting to lock nodes, release
# all the ones living on nodes unrelated to the current operation.
if level == locking.LEVEL_NODE and self.lock_instances:
self.affected_instances = []
if self.needed_locks[locking.LEVEL_NODE] is not locking.ALL_SET:
instances_keep = []
# Build list of instances to release
locked_i = self.owned_locks(locking.LEVEL_INSTANCE)
for instance_name, instance in self.cfg.GetMultiInstanceInfo(locked_i):
if (instance.disk_template in constants.DTS_INT_MIRROR and
self.op.node_name in instance.all_nodes):
_ReleaseLocks(self, locking.LEVEL_INSTANCE, keep=instances_keep)
assert (set(self.owned_locks(locking.LEVEL_INSTANCE)) ==
self.needed_locks[locking.LEVEL_INSTANCE] = \
def BuildHooksEnv(self):
"""Build hooks env.
......@@ -5306,6 +5293,25 @@ class LUNodeSetParams(LogicalUnit):
node = self.node = self.cfg.GetNodeInfo(self.op.node_name)
if self.lock_instances:
affected_instances = \
# Verify instance locks
owned_instances = self.owned_locks(locking.LEVEL_INSTANCE)
wanted_instances = frozenset(affected_instances.keys())
if wanted_instances - owned_instances:
raise errors.OpPrereqError("Instances affected by changing node %s's"
" secondary IP address have changed since"
" locks were acquired, wanted '%s', have"
" '%s'; retry the operation" %
affected_instances = None
if (self.op.master_candidate is not None or
self.op.drained is not None or
self.op.offline is not None):
......@@ -5416,15 +5422,19 @@ class LUNodeSetParams(LogicalUnit):
raise errors.OpPrereqError("Cannot change the secondary ip on a single"
" homed cluster", errors.ECODE_INVAL)
assert not (frozenset(affected_instances) -
if node.offline:
if self.affected_instances:
raise errors.OpPrereqError("Cannot change secondary ip: offline"
" node has instances (%s) configured"
" to use it" % self.affected_instances)
if affected_instances:
raise errors.OpPrereqError("Cannot change secondary IP address:"
" offline node has instances (%s)"
" configured to use it" %
# On online nodes, check that no instances are running, and that
# the node has the new ip and we can reach it.
for instance in self.affected_instances:
for instance in affected_instances.values():
_CheckInstanceDown(self, instance, "cannot change secondary ip")
_CheckNodeHasSecondaryIP(self,, self.op.secondary_ip, True)
......@@ -1334,6 +1334,22 @@ class ConfigWriter:
for instance in self._UnlockedGetInstanceList()])
return my_dict
@locking.ssynchronized(_config_lock, shared=1)
def GetInstancesInfoByFilter(self, filter_fn):
"""Get instance configuration with a filter.
@type filter_fn: callable
@param filter_fn: Filter function receiving instance object as parameter,
returning boolean. Important: this function is called while the
configuration locks is held. It must not do any complex work or call
functions potentially leading to a deadlock. Ideally it doesn't call any
other functions and just compares instance attributes.
return dict((name, inst)
for (name, inst) in self._config_data.instances.items()
if filter_fn(inst))
def AddNode(self, node, ec_id):
"""Add a node to the configuration.
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment