Commit b8ebd37b authored by Iustin Pop's avatar Iustin Pop

Instance migration: remove error on missing link

Since we don't support upgrades from 1.2.4 without restarting the
instance, the 'not restarted since 1.2.5' check/error is
wrong/misleading.

Since the live migration works anyway without the links (it recreates
them during the disk reconfiguration anyway), we remove the check and we
transform it into a warning (to the node daemon log only,
unfortunately).

For 2.3, we'll need to change the symlink creation from instance start
time to disk activation time (but that requires more RPC changes).
Signed-off-by: default avatarIustin Pop <iustin@google.com>
Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
parent 2c0be3d0
......@@ -805,7 +805,8 @@ def GetInstanceMigratable(instance):
for idx in range(len(instance.disks)):
link_name = _GetBlockDevSymlinkPath(iname, idx)
if not os.path.islink(link_name):
_Fail("Instance %s was not restarted since ganeti 1.2.5", iname)
logging.warning("Instance %s is missing symlink %s for disk %d",
iname, link_name, idx)
def GetAllInstancesInfo(hypervisor_list):
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment