daemon-util: pass --oknodo at rotate_logs
daemon-util's rotate_logs() did not pass --oknodo to start-stop-daemon while HUPing the daemon processes. As a result, rotate_logs would fail for a non-running daemon causing rotate_all_logs to exit prematurely. We can fix this by either passing --oknodo to start-stop-daemon, or have rotate_all_logs ignore any errors. The former is probably a safer approach - as it doesn't mask any potential coding errors in rotate_logs - and is also semantically correct (we only care about log rotation if a daemon is actually running). Signed-off-by:Apollon Oikonomopoulos <apoikos@gmail.com> Reviewed-by:
Guido Trotter <ultrotter@google.com>
Loading
Please register or sign in to comment