Commit 93e4c50b authored by Guido Trotter's avatar Guido Trotter
Browse files

Verify: add instance information to node_info

With this patch node_info is changed to store information about which primary
and secondary instances are configured on a node. This information is useful to
check memory and disk allocation. A list of non-redundant instances is also
collected at this stage.

Reviewed-by: iustinp
parent 9c9c7d30
......@@ -765,6 +765,7 @@ class LUVerifyCluster(NoHooksLU):
vg_name = self.cfg.GetVGName()
nodelist = utils.NiceSort(self.cfg.GetNodeList())
instancelist = utils.NiceSort(self.cfg.GetInstanceList())
i_non_redundant = [] # Non redundant instances
node_volume = {}
node_instance = {}
node_info = {}
......@@ -831,6 +832,8 @@ class LUVerifyCluster(NoHooksLU):
node_info[node] = {
"mfree": int(nodeinfo['memory_free']),
"dfree": int(nodeinfo['vg_free']),
"pinst": [],
"sinst": [],
except ValueError:
feedback_fn(" - ERROR: invalid value returned from node %s" % (node,))
......@@ -848,6 +851,32 @@ class LUVerifyCluster(NoHooksLU):
pnode = inst_config.primary_node
if pnode in node_info:
feedback_fn(" - ERROR: instance %s, connection to primary node"
" %s failed" % (instance, pnode))
bad = True
# If the instance is non-redundant we cannot survive losing its primary
# node, so we are not N+1 compliant. On the other hand we have no disk
# templates with more than one secondary so that situation is not well
# supported either.
# FIXME: does not support file-backed instances
if len(inst_config.secondary_nodes) == 0:
elif len(inst_config.secondary_nodes) > 1:
feedback_fn(" - WARNING: multiple secondaries for instance %s"
% instance)
for snode in inst_config.secondary_nodes:
if snode in node_info:
feedback_fn(" - ERROR: instance %s, connection to secondary node"
" %s failed" % (instance, snode))
feedback_fn("* Verifying orphan volumes")
result = self._VerifyOrphanVolumes(node_vol_should, node_volume,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment