Commit 81196341 authored by Iustin Pop's avatar Iustin Pop
Browse files

Implement verify checks for node/instance names

Since we index the nodes and instances by their name, we should have
checks that the dict key to mapping is correct.
Signed-off-by: default avatarIustin Pop <>
Reviewed-by: default avatarMichael Hanselmann <>
parent 44db3a6f
......@@ -351,6 +351,9 @@ class ConfigWriter:
# per-instance checks
for instance_name in data.instances:
instance = data.instances[instance_name]
if != instance_name:
result.append("instance '%s' is indexed by wrong name '%s'" %
(, instance_name))
if instance.primary_node not in data.nodes:
result.append("instance '%s' has invalid primary node '%s'" %
(instance_name, instance.primary_node))
......@@ -416,7 +419,10 @@ class ConfigWriter:
(mc_now, mc_max))
# node checks
for node in data.nodes.values():
for node_name, node in data.nodes.items():
if != node_name:
result.append("Node '%s' is indexed by wrong name '%s'" %
(, node_name))
if [node.master_candidate, node.drained, node.offline].count(True) > 1:
result.append("Node %s state is invalid: master_candidate=%s,"
" drain=%s, offline=%s" %
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment