Commit 7d60c3b5 authored by Helga Velroyen's avatar Helga Velroyen
Browse files

gnt-cluster modify: check vg name only on vm-capable nodes

This fixes issue 432: when setting the volume group name, the presence
of the volume group was checked on all nodes. This patch now restricts
the check only to the vm-capable ones.
Signed-off-by: default avatarHelga Velroyen <>
Reviewed-by: default avatarGuido Trotter <>
parent fc2318f7
......@@ -4213,10 +4213,14 @@ class LUClusterSetParams(LogicalUnit):
node_list = self.owned_locks(locking.LEVEL_NODE)
vm_capable_nodes = [
for node in self.cfg.GetAllNodesInfo().values()
if in node_list and node.vm_capable]
# if vg_name not None, checks given volume group on all nodes
if self.op.vg_name:
vglist = self.rpc.call_vg_list(node_list)
for node in node_list:
vglist = self.rpc.call_vg_list(vm_capable_nodes)
for node in vm_capable_nodes:
msg = vglist[node].fail_msg
if msg:
# ignoring down node
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment