Commit 76aef8fc authored by Michael Hanselmann's avatar Michael Hanselmann
Browse files

Add opcode to repair storage volumes

Signed-off-by: default avatarMichael Hanselmann <>
Reviewed-by: default avatarIustin Pop <>
parent 637b8d7e
......@@ -6441,6 +6441,62 @@ class TLReplaceDisks(Tasklet):
self._RemoveOldStorage(self.target_node, iv_names)
class LURepairNodeStorage(NoHooksLU):
"""Repairs the volume group on a node.
_OP_REQP = ["node_name"]
REQ_BGL = False
def CheckArguments(self):
node_name = self.cfg.ExpandNodeName(self.op.node_name)
if node_name is None:
raise errors.OpPrereqError("Invalid node name '%s'" % self.op.node_name)
self.op.node_name = node_name
def ExpandNames(self):
self.needed_locks = {
locking.LEVEL_NODE: [self.op.node_name],
def _CheckFaultyDisks(self, instance, node_name):
if _FindFaultyInstanceDisks(self.cfg, self.rpc, instance,
node_name, True):
raise errors.OpPrereqError("Instance '%s' has faulty disks on"
" node '%s'" % (, node_name))
def CheckPrereq(self):
"""Check prerequisites.
storage_type = self.op.storage_type
if (constants.SO_FIX_CONSISTENCY not in
constants.VALID_STORAGE_OPERATIONS.get(storage_type, [])):
raise errors.OpPrereqError("Storage units of type '%s' can not be"
" repaired" % storage_type)
# Check whether any instance on this node has faulty disks
for inst in _GetNodeInstances(self.cfg, self.op.node_name):
check_nodes = set(inst.all_nodes)
for inst_node_name in check_nodes:
self._CheckFaultyDisks(inst, inst_node_name)
def Exec(self, feedback_fn):
feedback_fn("Repairing storage unit '%s' on %s ..." %
(, self.op.node_name))
st_args = _GetStorageTypeArgs(self.cfg, self.op.storage_type)
result = self.rpc.call_storage_execute(self.op.node_name,
self.op.storage_type, st_args,,
result.Raise("Failed to repair storage unit '%s' on %s" %
(, self.op.node_name))
class LUGrowDisk(LogicalUnit):
"""Grow a disk of an instance.
......@@ -58,6 +58,7 @@ class Processor(object):
opcodes.OpQueryNodeVolumes: cmdlib.LUQueryNodeVolumes,
opcodes.OpQueryNodeStorage: cmdlib.LUQueryNodeStorage,
opcodes.OpModifyNodeStorage: cmdlib.LUModifyNodeStorage,
opcodes.OpRepairNodeStorage: cmdlib.LURepairNodeStorage,
opcodes.OpRemoveNode: cmdlib.LURemoveNode,
opcodes.OpSetNodeParams: cmdlib.LUSetNodeParams,
opcodes.OpPowercycleNode: cmdlib.LUPowercycleNode,
......@@ -381,6 +381,17 @@ class OpModifyNodeStorage(OpCode):
class OpRepairNodeStorage(OpCode):
"""Repairs the volume group on a node."""
OP_DSC_FIELD = "node_name"
__slots__ = OpCode.__slots__ + [
class OpSetNodeParams(OpCode):
"""Change the parameters of a node."""
......@@ -680,6 +691,7 @@ class OpTestAllocator(OpCode):
"os", "tags", "nics", "vcpus", "hypervisor",
OP_MAPPING = dict([(v.OP_ID, v) for v in globals().values()
if (isinstance(v, type) and issubclass(v, OpCode) and
hasattr(v, "OP_ID"))])
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment