Commit 6de7c41d authored by Iustin Pop's avatar Iustin Pop
Browse files

Add a FieldSet class for variable parameter sets

This patch adds a _FieldSet class that can be used for the new variable
parameter sets: e.g. the sda_size will change to disk/0.size (or
similar) and we need to both check validity and extract the index of the
parameter easily.

The patch also sorts the unittest list in

Reviewed-by: ultrotter
parent e6416152
......@@ -191,18 +191,19 @@ TEST_FILES = \
dist_TESTS = \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
test/ \
nodist_TESTS =
......@@ -32,6 +32,7 @@ import re
import platform
import logging
import copy
import itertools
from ganeti import ssh
from ganeti import utils
......@@ -322,6 +323,48 @@ class NoHooksLU(LogicalUnit):
HTYPE = None
class _FieldSet(object):
"""A simple field set.
Among the features are:
- checking if a string is among a list of static string or regex objects
- checking if a whole list of string matches
- returning the matching groups from a regex match
Internally, all fields are held as regular expression objects.
def __init__(self, *items):
self.items = [re.compile("^%s$" % value) for value in items]
def Extend(self, other_set):
"""Extend the field set with the items from another one"""
def Matches(self, field):
"""Checks if a field matches the current set
@type field: str
@param field: the string to match
@return: either False or a regular expression match object
for m in itertools.ifilter(None, (val.match(field) for val in self.items)):
return m
return False
def NonMatching(self, items):
"""Returns the list of fields not matching the current set
@type items: list
@param items: the list of fields to check
@rtype: list
@return: list of non-matching fields
return [val for val in items if not self.Matches(val)]
def _GetWantedNodes(lu, nodes):
"""Returns list of checked and expanded node names.
# Copyright (C) 2008 Google Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
# This program is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# General Public License for more details.
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
# 0.0510-1301, USA.
"""Script for unittesting the cmdlib module"""
import os
import unittest
import time
import Queue
from ganeti import cmdlib
from ganeti import errors
class FieldSetTestCase(unittest.TestCase):
"""Test case for FieldSets"""
def testSimpleMatch(self):
f = cmdlib._FieldSet("a", "b", "c", "def")
self.failIf(f.Matches("d"), "Substring matched")
self.failIf(f.Matches("defghi"), "Prefix string matched")
self.failIf(f.NonMatching(["b", "c"]))
self.failIf(f.NonMatching(["a", "b", "c", "def"]))
self.failUnless(f.NonMatching(["a", "d"]))
def testRegexMatch(self):
f = cmdlib._FieldSet("a", "b([0-9]+)", "c")
self.failIf(f.NonMatching(["b12", "c"]))
self.failUnless(f.NonMatching(["a", "1"]))
if __name__ == '__main__':
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment