Commit 52b783c2 authored by Iustin Pop's avatar Iustin Pop
Browse files

LUSetClusterParms: fix validation of beparams

Since the contents of the dict is validated via the ForceDictType, we can
simply require that it is a dict here. The previous check was wrong, as it was
copied from the HV checks (which also doesn't verify the leaf dict type).
Signed-off-by: default avatarIustin Pop <>
Reviewed-by: default avatarMichael Hanselmann <>
parent 2ba14c2f
......@@ -2613,7 +2613,7 @@ class LUSetClusterParams(LogicalUnit):
("enabled_hypervisors", None,
_TOr(_TAnd(_TListOf(_TElemOf(constants.HYPER_TYPES)), _TTrue), _TNone)),
("hvparams", None, _TOr(_TDictOf(_TNonEmptyString, _TDict), _TNone)),
("beparams", None, _TOr(_TDictOf(_TNonEmptyString, _TDict), _TNone)),
("beparams", None, _TOr(_TDict, _TNone)),
("os_hvp", None, _TOr(_TDictOf(_TNonEmptyString, _TDict), _TNone)),
("osparams", None, _TOr(_TDictOf(_TNonEmptyString, _TDict), _TNone)),
("candidate_pool_size", None, _TOr(_TStrictPositiveInt, _TNone)),
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment