Commit 4fae38c5 authored by Guido Trotter's avatar Guido Trotter
Browse files

ConfigWriter: move _temporary_ids to reservation

In order to do this we need to pass a job id when reserving a resource.
We have one during _EnsureUUIDs because we passed it in from AddNode and
AddInstance. During config upgrade we use a fake job ID which we then
cleanup. We can delete the _CleanupTemporaryIDs code, since the cleanup
is going to be done at job finish time by mcpu.
Signed-off-by: default avatarGuido Trotter <>
Reviewed-by: default avatarIustin Pop <>
parent 013da361
......@@ -5311,7 +5311,7 @@ def _GenerateUniqueNames(lu, exts):
results = []
for val in exts:
new_id = lu.cfg.GenerateUniqueID()
new_id = lu.cfg.GenerateUniqueID(lu.proc.GetECId())
results.append("%s%s" % (new_id, val))
return results
......@@ -47,6 +47,9 @@ from ganeti import serializer
_config_lock = locking.SharedLock()
# job id used for resource management at config upgrade time
def _ValidateConfig(data):
"""Verifies that a configuration objects looks valid.
......@@ -132,7 +135,7 @@ class ConfigWriter:
self._cfg_file = constants.CLUSTER_CONF_FILE
self._cfg_file = cfg_file
self._temporary_ids = set()
self._temporary_ids = TemporaryReservationManager()
self._temporary_drbds = {}
self._temporary_macs = set()
# Note: in order to prevent errors when resolving our name in
......@@ -225,14 +228,14 @@ class ConfigWriter:
existing = set()
if include_temporary:
existing.update([i.uuid for i in self._AllUUIDObjects() if i.uuid])
return existing
def _GenerateUniqueID(self):
def _GenerateUniqueID(self, ec_id):
"""Generate an unique UUID.
This checks the current node, instances and disk names for
......@@ -242,33 +245,20 @@ class ConfigWriter:
@return: the unique id
existing = self._AllIDs(include_temporary=True)
retries = 64
while retries > 0:
unique_id = utils.NewUUID()
if unique_id not in existing and unique_id is not None:
raise errors.ConfigurationError("Not able generate an unique ID"
" (last tried ID: %s" % unique_id)
return unique_id
existing = self._AllIDs(include_temporary=False)
return self._temporary_ids.Generate(existing, utils.NewUUID, ec_id)
@locking.ssynchronized(_config_lock, shared=1)
def GenerateUniqueID(self):
def GenerateUniqueID(self, ec_id):
"""Generate an unique ID.
This is just a wrapper over the unlocked version.
return self._GenerateUniqueID()
def _CleanupTemporaryIDs(self):
"""Cleanups the _temporary_ids structure.
@type ec_id: string
@param ec_id: unique id for the job to reserve the id to
existing = self._AllIDs(include_temporary=False)
self._temporary_ids = self._temporary_ids - existing
return self._GenerateUniqueID(ec_id)
def _AllMACs(self):
"""Return all MACs present in the config.
......@@ -821,7 +811,7 @@ class ConfigWriter:
if not item.uuid:
item.uuid = self._GenerateUniqueID()
item.uuid = self._GenerateUniqueID(ec_id)
elif item.uuid in self._AllIDs(temporary=True):
raise errors.ConfigurationError("Cannot add '%s': UUID already in use" %
(, item.uuid))
......@@ -1205,10 +1195,14 @@ class ConfigWriter:
modified = False
for item in self._AllUUIDObjects():
if item.uuid is None:
item.uuid = self._GenerateUniqueID()
item.uuid = self._GenerateUniqueID(_UPGRADE_CONFIG_JID)
modified = True
if modified:
# This is ok even if it acquires the internal lock, as _UpgradeConfig is
# only called at config init time, without the lock held
def _DistributeConfig(self, feedback_fn):
"""Distribute the configuration to the other nodes.
......@@ -1260,11 +1254,6 @@ class ConfigWriter:
assert feedback_fn is None or callable(feedback_fn)
# First, cleanup the _temporary_ids set, if an ID is now in the
# other objects it should be discarded to prevent unbounded growth
# of that structure
# Warn on config errors, but don't abort the save - the
# configuration has already been modified, and we can't revert;
# the best we can do is to warn the user and save as is, leaving
......@@ -1441,5 +1430,5 @@ class ConfigWriter:
"""Drop per-execution-context reservations
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment