Commit 1986b21f authored by Michael Hanselmann's avatar Michael Hanselmann
Browse files

cmdlib: Allow specifying lock level when calculating node locks

This is needed to lock node resources.
Signed-off-by: default avatarMichael Hanselmann <>
Reviewed-by: default avatarGuido Trotter <>
parent b2acdbdc
......@@ -349,7 +349,8 @@ class LogicalUnit(object):
self.needed_locks[locking.LEVEL_INSTANCE] = self.op.instance_name
def _LockInstancesNodes(self, primary_only=False):
def _LockInstancesNodes(self, primary_only=False,
"""Helper function to declare instances' nodes for locking.
This function should be called after locking one or more instances to lock
......@@ -370,9 +371,10 @@ class LogicalUnit(object):
@type primary_only: boolean
@param primary_only: only lock primary nodes of locked instances
@param level: Which lock level to use for locking nodes
assert locking.LEVEL_NODE in self.recalculate_locks, \
assert level in self.recalculate_locks, \
"_LockInstancesNodes helper function called with no nodes to recalculate"
# TODO: check if we're really been called with the instance locks held
......@@ -387,12 +389,14 @@ class LogicalUnit(object):
if not primary_only:
if self.recalculate_locks[locking.LEVEL_NODE] == constants.LOCKS_REPLACE:
self.needed_locks[locking.LEVEL_NODE] = wanted_nodes
elif self.recalculate_locks[locking.LEVEL_NODE] == constants.LOCKS_APPEND:
if self.recalculate_locks[level] == constants.LOCKS_REPLACE:
self.needed_locks[level] = wanted_nodes
elif self.recalculate_locks[level] == constants.LOCKS_APPEND:
raise errors.ProgrammerError("Unknown recalculation mode")
del self.recalculate_locks[locking.LEVEL_NODE]
del self.recalculate_locks[level]
class NoHooksLU(LogicalUnit): # pylint: disable=W0223
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment