Commit 191712c0 authored by Iustin Pop's avatar Iustin Pop

Add a info subcommand to gnt-job

Currently, it is hard to examine a job in detail; the output of ‘gnt-job
list’ is not easy to parse.

The patch adds a ‘gnt-job info’ command that is (vaguely) similar to
‘gnt-instance info’ in that it shows in a somewhat easy to understand
format the details of a job.

The result formatter is the most complicated part, since the results are
not standardized; the code attempts to format nicely the most common
result types (as taken from a random job list), via a generic algorithm.

Reviewed-by: imsnah
parent 60dd1473
......@@ -114,6 +114,70 @@ def CancelJobs(opts, args):
return 0
def ShowJobs(opts, args):
"""List the jobs
def format(level, text):
"""Display the text indented."""
print "%s%s" % (" " * level, text)
def result_helper(value):
"""Format a result field in a nice way."""
if isinstance(value, (tuple, list)):
return "[%s]" % (", ".join(str(elem) for elem in value))
return str(value)
selected_fields = ["id", "status", "ops", "opresult", "opstatus"]
result = GetClient().QueryJobs(args, selected_fields)
first = True
for job_id, status, ops, opresult, opstatus in result:
if not first:
format(0, "")
first = False
format(0, "Job ID: %s" % job_id)
if status in _USER_JOB_STATUS:
status = _USER_JOB_STATUS[status]
raise errors.ProgrammerError("Unknown job status code '%s'" % val)
format(1, "Status: %s" % status)
format(1, "Opcodes:")
for opcode, result, status in zip(ops, opresult, opstatus):
format(2, "%s" % opcode["OP_ID"])
format(3, "Status: %s" % status)
format(3, "Input fields:")
for key, val in opcode.iteritems():
if key == "OP_ID":
if isinstance(val, (tuple, list)):
val = ",".join(val)
format(4, "%s: %s" % (key, val))
if result is None:
format(3, "No output data")
elif isinstance(result, (tuple, list)):
if not result:
format(3, "Result: empty sequence")
format(3, "Result:")
for elem in result:
format(4, result_helper(elem))
elif isinstance(result, dict):
if not result:
format(3, "Result: empty dictionary")
for key, val in result.iteritems():
format(4, "%s: %s" % (key, result_helper(val)))
format(3, "Result: %s" % result)
return 0
commands = {
'list': (ListJobs, ARGS_NONE,
......@@ -130,6 +194,9 @@ commands = {
"<job-id> [<job-id> ...]",
"Cancel specified jobs"),
'info': (ShowJobs, ARGS_ANY, [DEBUG_OPT],
"<job-id> [<job-id> ...]",
"Show detailed information about the specified jobs"),
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment