• Adeodato Simo's avatar
    Cluster verify: don't assume we're verifying all nodes/instances · cf692cd0
    Adeodato Simo authored
    
    
    This commit fixes a few initial simple cases in which it was assumed that
    we're always working over the whole cluster. With this change, we
    differentiate between "nodes/instances to verify" and "checks that need
    cluster-wide information".
    
    In particular:
    
      - retrieve hypervisor parameters always from all instances
      - always specify full node list in NV_NODELIST
      - retrieve OOB path from all nodes
      - verify DRBD devices against the full set of instances (this ensures
        minors get properly verified even if an instance is split between groups)
      - look up node groups against the set of all nodes (to avoid tracebacks
        in case instances are split between groups)
      - determine whether running instances are unknown by checking against the
        full list of instances
    
    Behavior in all cases stays the same if still running over the whole
    cluster.
    
    Signed-off-by: default avatarAdeodato Simo <dato@google.com>
    Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
    Reviewed-by: default avatarIustin Pop <iustin@google.com>
    cf692cd0