• Michael Hanselmann's avatar
    TLReplaceDisks: Move assertion checking locks · a9b42993
    Michael Hanselmann authored
    Commit 1bee66f3
    
     added assertions for ensuring only the necessary locks
    are kept while replacing disks. One of them makes sure locks have been
    released during the operation. Unfortunately the commit added the check
    as part of a “finally” branch, which is also run when an exception is
    thrown (in which case the locks may not have been released yet). Errors
    could be masked by the assertion error. Moving the check out of the
    “finally” branch fixes the issue.
    Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
    Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
    a9b42993
cmdlib.py 406 KB