• Iustin Pop's avatar
    Fix HV/OS parameter validation on non-vm nodes · 9c24736c
    Iustin Pop authored
    Currently, there is at least one LU that does wrong validation of HV
    parameters (against all nodes, LUClusterSetParams). It's possible to
    fix this case, but I went and modified the base functions to filter
    out non-vm_capable nodes so all callers are protected.
    Note: the _CheckOSParams function is never called with all nodes list,
    so modifying it shouldn't be needed. However, I think it's safe to do
    so (and it shouldn't hurt as an instance's node shouldn't ever lack
    the vm_capable bit).
    Signed-off-by: default avatarIustin Pop <iustin@google.com>
    Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
cmdlib.py 397 KB