Skip to content
  • Apollon Oikonomopoulos's avatar
    daemon-util: pass --oknodo at rotate_logs · 9a8e4b73
    Apollon Oikonomopoulos authored
    
    
    daemon-util's rotate_logs() did not pass --oknodo to start-stop-daemon while
    HUPing the daemon processes. As a result, rotate_logs would fail for a
    non-running daemon causing rotate_all_logs to exit prematurely.
    
    We can fix this by either passing --oknodo to start-stop-daemon, or have
    rotate_all_logs ignore any errors. The former is probably a safer approach - as
    it doesn't mask any potential coding errors in rotate_logs - and is also
    semantically correct (we only care about log rotation if a daemon is actually
    running).
    
    Signed-off-by: default avatarApollon Oikonomopoulos <apoikos@gmail.com>
    Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
    9a8e4b73