Skip to content
  • Iustin Pop's avatar
    5183e8be
    Convert query path from string errors to GanetiException · 5183e8be
    Iustin Pop authored
    
    
    This patch converts all the call paths from 'Result' (which contains
    just string errors) to 'ErrorResult', which holds
    GanetiException-encoded errors. We can now return proper
    OpPrereq/OpExec errors to the clients of the luxi/query socket.
    
    The patch touches many files as we had to convert the entire call
    chains in a single round. But it should be pretty straightforward
    otherwise:
    
    - change 'Result' into 'ErrorResult'
    - add error annotations: change "Bad msg" into "Bad (XXXEror msg)"
    - add a helper function for confd, where we don't send to client
      formatted exceptions, to convert back from ErrorResult into Result
    - change tests similarly, where needed
    
    Signed-off-by: default avatarIustin Pop <iustin@google.com>
    Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
    5183e8be
    Convert query path from string errors to GanetiException
    Iustin Pop authored
    
    
    This patch converts all the call paths from 'Result' (which contains
    just string errors) to 'ErrorResult', which holds
    GanetiException-encoded errors. We can now return proper
    OpPrereq/OpExec errors to the clients of the luxi/query socket.
    
    The patch touches many files as we had to convert the entire call
    chains in a single round. But it should be pretty straightforward
    otherwise:
    
    - change 'Result' into 'ErrorResult'
    - add error annotations: change "Bad msg" into "Bad (XXXEror msg)"
    - add a helper function for confd, where we don't send to client
      formatted exceptions, to convert back from ErrorResult into Result
    - change tests similarly, where needed
    
    Signed-off-by: default avatarIustin Pop <iustin@google.com>
    Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
Loading