Skip to content
Snippets Groups Projects
  • Klaus Aehlig's avatar
    Make _CreateDisk clean up partially created disks on failure · 7d3484b8
    Klaus Aehlig authored
    
    _CreateDisk used to just throw an exception if _CreateBlockDev failed
    leaving the caller in the state that some disks were created, without
    precise knowledge which. Usually, the clean up then overapproximated
    by removing all disks of the instance. This can cause data loss in case
    the disk creation failed because of a file being already in the place
    where the disk is to be created.
    
    With this patch, upon failure, _CreateDisk removes the disks that were
    successfully created, leaving a well-defined state.
    
    Signed-off-by: default avatarKlaus Aehlig <aehlig@google.com>
    Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
    7d3484b8