• Iustin Pop's avatar
    Further fixes to instance policy validation · 57dc299a
    Iustin Pop authored
    As a followup from "Remove extraneous check in policy creation", there
    are more places where we build an ipolicy, and then manually check for
    its validity. This is very bad style, as it duplicates the
    verification code across many places.
    This patch removes all such explicit checks (except for one in
    cmdlib.py which is correct), and instead does a bit more validation in
    the builder functions or in the actual dedicated verification
    functions. It also fixes cluster init which used the wrong,
    non-completed ipolicy (this was not detected before as we did call
    check on it, but otherwise we ignored it), and fixes a too-strong
    assert (due to the call chain, we first create the ipolicy from
    cmdline params, and only then we fill it).
    Finally, it removes an extraneous logging.info which I forgot from
    Signed-off-by: default avatarIustin Pop <iustin@google.com>
    Reviewed-by: default avatarRené Nussbaumer <rn@google.com>