Skip to content
  • Michael Hanselmann's avatar
    RAPI client: Fix SSL error reporting for real · 0d9bc5d2
    Michael Hanselmann authored
    My previous patch, commit 857705e8
    
    , helped in one particular
    situation where the exception didn't contain any arguments
    (pyOpenSSL reporting a WantReadError, which shouldn't occur with a
    blocking socket anyway). With this patch, more common and uncommon
    errors should be easy to recognize.
    
    SSL errors without any of these patches:
    “ganeti.rapi.client.CertificateError: SSL issue:
    [('SSL routines', 'SSL3_GET_SERVER_CERTIFICATE',
    'certificate verify failed')]”
    
    SSL errors with both patches:
    “ganeti.rapi.client.CertificateError: SSL issue:
    [('SSL routines', 'SSL3_GET_SERVER_CERTIFICATE',
    'certificate verify failed')] (<OpenSSL.SSL.Error
    instance at 0x…>)”
    
    WantReadError without any of these two patches:
    “ganeti.rapi.client.CertificateError: SSL issue: ”
    
    WantReadError with both patches:
    “ganeti.rapi.client.CertificateError: SSL issue:
    (<OpenSSL.SSL.WantReadError instance at 0x…>)”
    
    Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
    Reviewed-by: default avatarIustin Pop <iustin@google.com>
    0d9bc5d2