• Iustin Pop's avatar
    Conver node_leave_cluster rpc to new style result · 0623d351
    Iustin Pop authored
    
    
    This patch converts this rpc call to the new style result, and also
    changes in the process the meaning of the QuitGanetiException's
    arguments and the node daemon rpc call exception handler.
    
    The problem with the exception handler is that we used a two-stage one,
    and the inner used to catch all exception (including this one), so in
    the logs we always had an exception logged, instead of the normal
    'leaving cluster message'. The patch also adds logging of the
    exception's arguments, so that we have a trail in the logs about the
    shutdown mode.
    
    The exception's arguments were reversed from the normal RPC results
    style. While it makes somewhat more sense for this exception, we change
    them such that they match the rpc result format.
    Signed-off-by: default avatarIustin Pop <iustin@google.com>
    Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
    0623d351
cmdlib.py 253 KB