GitLab

* Add a function logic/utils.py to check the length of a string and
raise an API fault with the corresponding message.
* Check the length of the name of servers/ports/networks/subnets

Do not have a default value from 'link' attribute of IP_LESS_ROUTED
networks. Instead if the admin does not specify a value in
network-create command, uniquely name the networks by with the
BACKEND_PREFIX_ID and network id, e.g. snf-link-42.

Before deleting a network, the network is marked as drained to be
excluded from automatic IP allocation. The state of the network that is
exposed in the API is always 'SNF:DRAINED' if the drained flag is set.
This resulted in deleted networks to appear as 'SNF:DRAINED'. This
commit fixes this issue by clearing the 'drained' flag when deleting the
network.

Also, this commit sets the 'drained' flag only when deleting public
networks that can take part in automatic IP allocation. For private
networs setting this flag is not needed.

Fix when network is created in the Ganeti backends. The network must be
created in the Ganeti backends only after IPv4 or/and IPv6 subnet has
been created. This commit moves the code that created the network in the
Ganet backend out of 'network.create' function to a separate function
that is called at the end of command.

Also, this commit fixes some small issues and removes unnecessary
options.

* Merge snf-manage subnet-create into snf-manage network-create

Do not allow creation of new ports and reservation of floating IPs on
network that are being deleted. Currently the state of the network
changes only when the network gets deleted from all backends. So we
check if a network is being deleted by checking if the action of the
network is 'DESTROY'.

* Do not delete the network from the DB if it has associated floating
  IPs. This should never be the case because a check is made before
  deleting the network, however this check is added for safety.
* Do not allow deleting a network if there are still ports configured on
  on that network. Until now this check was for machines, but there may
  be ports that are not connected to any machine.
* Delete subnet IP pools when network is deleted.
* Get network in locked mode in network-remove cmd.
* Log error if trying to release an IPv4 address that does not belong to
  any of the IP pools of the associated subnet.
* Excluded deleted IPv4 addresses when reconciling IP pools.
* Do not set the network action to destroy when removing network from
  some backend.

* Fix IP pools of subnets to take into account the 'offset' when searching
if a pool contains an IP address and when converting from value to index
and from index to value.
* Fix the way subnets are created from 'logic/networks'
* Rename 'validate_network_params' function to 'validate_subnet_params'
  and move it from 'networks' to 'subnets' packages.

Set 'external_router' attribute of created networks to True, if a
network is a public network.

Create IPv4 address pool when creating the network. This is a temporary
commit to make logic network work, since subnet and pool creation must
be moved out of the network creation part.

Refactor Cyclades code so that it follows the new models for Networks,
Subnets and IPAddresses. This refactor is not complete. Instead is the
necessary refactor for making tests for server API calls succeed.

Check that IPv6 network netmask is /64, because this is imposed by the
'mac2eui64' utility that generates EUI-64 addresses from 48-bit MAC
addresses.

Refs #4201

Move code for network parameters validation from 'api' module to 'logic'.

Update snf-manage network-create command to take a list of comma
seperated backend IDs to create the network to.

Merge code from logic/networks.py and network management commands.

Add a check when creating IP_LESS_ROUTED networks, that the connectivity
link is not already used by another network.

Do not issue commission for public networks, since they do not have an
owner.

Move code checks from network-create management command to
logic/networks.py.

Also create common decorator for management commands to convert api
faults to command errors.

Remove code handling networks from network API views to logic.networks