Skip to content

GitLab

Commit bf5cd5c4 authored by Sofia Papagiannaki's avatar Sofia Papagiannaki
Browse files

pithos: Fix ordering in detailed listing of public objects 

Refs: #4727
parent f3d87ae5
Hide whitespace changes
Inline Side-by-side
snf-pithos-app/pithos/api/test/containers.py
View file @ bf5cd5c4
......@@ -198,14 +198,26 @@ class ContainerGet(PithosAPITest):
# share an object
cname = self.cnames[0]
onames = self.objects[cname].keys()
oname = onames.pop()
url = join_urls(self.pithos_path, self.user, cname, oname)
shared1 = onames.pop()
url = join_urls(self.pithos_path, self.user, cname, shared1)
r = self.post(url, content_type='', HTTP_X_OBJECT_SHARING='read=*')
self.assertEqual(r.status_code, 202)
# share another object
shared2 = onames.pop()
url = join_urls(self.pithos_path, self.user, cname, shared2)
r = self.post(url, content_type='', HTTP_X_OBJECT_SHARING='read=*')
self.assertEqual(r.status_code, 202)
# publish another object
public1 = onames.pop()
url = join_urls(self.pithos_path, self.user, cname, public1)
r = self.post(url, content_type='', HTTP_X_OBJECT_PUBLIC='true')
self.assertEqual(r.status_code, 202)
# publish another object
other = onames.pop()
url = join_urls(self.pithos_path, self.user, cname, other)
public2 = onames.pop()
url = join_urls(self.pithos_path, self.user, cname, public2)
r = self.post(url, content_type='', HTTP_X_OBJECT_PUBLIC='true')
self.assertEqual(r.status_code, 202)
......@@ -216,7 +228,7 @@ class ContainerGet(PithosAPITest):
objects = r.content.split('\n')
if '' in objects:
objects.remove('')
self.assertEqual([oname], objects)
self.assertEqual(sorted([shared1, shared2]), objects)
# list detailed shared and assert only the shared object is returned
url = join_urls(self.pithos_path, self.user, cname)
......@@ -226,13 +238,19 @@ class ContainerGet(PithosAPITest):
objects = json.loads(r.content)
except:
self.fail('json format expected')
self.assertEqual([oname], [o['name'] for o in objects])
self.assertTrue('x_object_sharing' in objects[0])
self.assertTrue('x_object_public' not in objects[0])
l = sorted([shared1, shared2])
i = 0
for name in l:
self.assertEqual(objects[i]['name'], name)
self.assertEqual(objects[i]['bytes'],
len(self.objects[cname][name]))
self.assertTrue('x_object_sharing' in objects[i])
self.assertTrue('x_object_public' not in objects[i])
i += 1
# publish the shared object and assert it is still listed in the
# shared objects
url = join_urls(self.pithos_path, self.user, cname, oname)
url = join_urls(self.pithos_path, self.user, cname, shared1)
r = self.post(url, content_type='', HTTP_X_OBJECT_PUBLIC='true')
self.assertEqual(r.status_code, 202)
url = join_urls(self.pithos_path, self.user, cname)
......@@ -242,12 +260,20 @@ class ContainerGet(PithosAPITest):
objects = json.loads(r.content)
except:
self.fail('json format expected')
self.assertEqual([oname], [o['name'] for o in objects])
self.assertTrue('x_object_sharing' in objects[0])
self.assertTrue('x_object_public' in objects[0])
i = 0
for name in l:
self.assertEqual(objects[i]['name'], name)
self.assertEqual(objects[i]['bytes'],
len(self.objects[cname][name]))
self.assertTrue('x_object_sharing' in objects[i])
if name == shared1:
self.assertTrue('x_object_public' in objects[i])
else:
self.assertTrue('x_object_public' not in objects[i])
i += 1
# create child object
descendant = strnextling(oname)
descendant = strnextling(shared1)
self.upload_object(cname, descendant)
# request shared and assert child obejct is not listed
url = join_urls(self.pithos_path, self.user, cname)
......@@ -256,13 +282,13 @@ class ContainerGet(PithosAPITest):
objects = r.content.split('\n')
if '' in objects:
objects.remove('')
self.assertTrue(oname in objects)
self.assertTrue(shared1 in objects)
self.assertTrue(descendant not in objects)
# check folder inheritance
oname, _ = self.create_folder(cname, HTTP_X_OBJECT_SHARING='read=*')
folder, _ = self.create_folder(cname, HTTP_X_OBJECT_SHARING='read=*')
# create child object
descendant = '%s/%s' % (oname, get_random_name())
descendant = '%s/%s' % (folder, get_random_name())
self.upload_object(cname, descendant)
# request shared
url = join_urls(self.pithos_path, self.user, cname)
......@@ -271,33 +297,45 @@ class ContainerGet(PithosAPITest):
objects = r.content.split('\n')
if '' in objects:
objects.remove('')
self.assertTrue(oname in objects)
self.assertTrue(folder in objects)
self.assertTrue(descendant in objects)
def test_list_public(self):
# publish an object
cname = self.cnames[0]
onames = self.objects[cname].keys()
oname = onames.pop()
other = onames.pop()
# publish an object
url = join_urls(self.pithos_path, self.user, cname, oname)
public1 = onames.pop()
url = join_urls(self.pithos_path, self.user, cname, public1)
r = self.post(url, content_type='', HTTP_X_OBJECT_PUBLIC='true')
self.assertEqual(r.status_code, 202)
# publish another
public2 = onames.pop()
url = join_urls(self.pithos_path, self.user, cname, public2)
r = self.post(url, content_type='', HTTP_X_OBJECT_PUBLIC='true')
self.assertEqual(r.status_code, 202)
# share an object
shared1 = onames.pop()
url = join_urls(self.pithos_path, self.user, cname, shared1)
r = self.post(url, content_type='', HTTP_X_OBJECT_SHARING='read=alice')
self.assertEqual(r.status_code, 202)
# share another
url = join_urls(self.pithos_path, self.user, cname, other)
shared2 = onames.pop()
url = join_urls(self.pithos_path, self.user, cname, shared2)
r = self.post(url, content_type='', HTTP_X_OBJECT_SHARING='read=alice')
self.assertEqual(r.status_code, 202)
# list public and assert only the public object is returned
url = join_urls(self.pithos_path, self.user, cname)
r = self.get('%s?public=' % url)
objects = r.content.split('\n')
self.assertEqual(r.status_code, 200)
self.assertTrue(oname in r.content.split('\n'))
(self.assertTrue(object not in objects) for object in o_names[1:])
objects = r.content.split('\n')
if '' in objects:
objects.remove('')
self.assertEqual(sorted([public1, public2]), objects)
# list detailed public and assert only the public object is returned
url = join_urls(self.pithos_path, self.user, cname)
......@@ -307,13 +345,19 @@ class ContainerGet(PithosAPITest):
objects = json.loads(r.content)
except:
self.fail('json format expected')
self.assertEqual([oname], [obj['name'] for obj in objects])
self.assertTrue('x_object_sharing' not in objects[0])
self.assertTrue('x_object_public' in objects[0])
l = sorted([public1, public2])
i = 0
for name in l:
self.assertEqual(objects[i]['name'], name)
self.assertEqual(objects[i]['bytes'],
len(self.objects[cname][name]))
self.assertTrue('x_object_sharing' not in objects[i])
self.assertTrue('x_object_public' in objects[i])
i += 1
# share the public object and assert it is still listed in the
# public objects
url = join_urls(self.pithos_path, self.user, cname, oname)
url = join_urls(self.pithos_path, self.user, cname, public1)
r = self.post(url, content_type='', HTTP_X_OBJECT_SHARING='read=alice')
self.assertEqual(r.status_code, 202)
url = join_urls(self.pithos_path, self.user, cname)
......@@ -323,9 +367,16 @@ class ContainerGet(PithosAPITest):
objects = json.loads(r.content)
except:
self.fail('json format expected')
self.assertEqual([oname], [obj['name'] for obj in objects])
self.assertTrue('x_object_sharing' in objects[0])
self.assertTrue('x_object_public' in objects[0])
i = 0
for name in l:
self.assertEqual(objects[i]['name'], name)
self.assertEqual(objects[i]['bytes'],
len(self.objects[cname][name]))
if name == public1:
self.assertTrue('x_object_sharing' in objects[i])
else:
self.assertTrue('x_object_sharing' not in objects[i])
i += 1
url = join_urls(self.pithos_path, self.user, cname)
......@@ -339,7 +390,7 @@ class ContainerGet(PithosAPITest):
self.assertEqual(r.status_code, 403)
# create child object
descendant = strnextling(oname)
descendant = strnextling(public1)
self.upload_object(cname, descendant)
# request public and assert child obejct is not listed
r = self.get('%s?public=' % url)
......@@ -347,34 +398,47 @@ class ContainerGet(PithosAPITest):
if '' in objects:
objects.remove('')
self.assertEqual(r.status_code, 200)
self.assertTrue(oname in objects)
(self.assertTrue(o not in objects) for o in o_names[1:])
self.assertTrue(public1 in objects)
self.assertTrue(descendant not in objects)
# test folder inheritance
oname, _ = self.create_folder(cname, HTTP_X_OBJECT_PUBLIC='true')
folder, _ = self.create_folder(cname, HTTP_X_OBJECT_PUBLIC='true')
# create child object
descendant = '%s/%s' % (oname, get_random_name())
descendant = '%s/%s' % (folder, get_random_name())
self.upload_object(cname, descendant)
# request public
r = self.get('%s?public=' % url)
self.assertEqual(r.status_code, 200)
objects = r.content.split('\n')
self.assertTrue(oname in objects)
self.assertTrue(folder in objects)
self.assertTrue(descendant not in objects)
def test_list_shared_public(self):
# publish an object
cname = self.cnames[0]
container_url = join_urls(self.pithos_path, self.user, cname)
onames = self.objects[cname].keys()
oname = onames.pop()
url = join_urls(container_url, oname)
# publish an object
public1 = onames.pop()
url = join_urls(container_url, public1)
r = self.post(url, content_type='', HTTP_X_OBJECT_PUBLIC='true')
self.assertEqual(r.status_code, 202)
# publish another
public2 = onames.pop()
url = join_urls(container_url, public2)
r = self.post(url, content_type='', HTTP_X_OBJECT_PUBLIC='true')
self.assertEqual(r.status_code, 202)
# share an object
shared1 = onames.pop()
url = join_urls(container_url, shared1)
r = self.post(url, content_type='', HTTP_X_OBJECT_SHARING='read=alice')
self.assertEqual(r.status_code, 202)
# share another
other = onames.pop()
url = join_urls(container_url, other)
shared2 = onames.pop()
url = join_urls(container_url, shared2)
r = self.post(url, content_type='', HTTP_X_OBJECT_SHARING='read=alice')
self.assertEqual(r.status_code, 202)
......@@ -382,12 +446,15 @@ class ContainerGet(PithosAPITest):
r = self.get('%s?shared=&public=&format=json' % container_url)
self.assertEqual(r.status_code, 200)
objects = json.loads(r.content)
self.assertEqual([o['name'] for o in objects], sorted([oname, other]))
for o in objects:
if o['name'] == oname:
self.assertTrue('x_object_public' in o.keys())
elif o['name'] == other:
self.assertTrue('x_object_sharing' in o.keys())
l = sorted([public1, public2, shared1, shared2])
i = 0
for name in l:
self.assertEqual(objects[i]['name'], name)
self.assertEqual(objects[i]['bytes'],
len(self.objects[cname][name]))
self.assertTrue('x_object_sharing' in objects[i] or
'x_object_public' in objects[i])
i += 1
# assert not listing shared and public to a not shared user
r = self.get('%s?shared=&public=&format=json' % container_url,
......@@ -400,7 +467,7 @@ class ContainerGet(PithosAPITest):
self.assertEqual(r.status_code, 403)
# create child object
descendant = strnextling(oname)
descendant = strnextling(public1)
self.upload_object(cname, descendant)
# request public and assert child obejct is not listed
r = self.get('%s?shared=&public=' % container_url)
......@@ -408,13 +475,12 @@ class ContainerGet(PithosAPITest):
if '' in objects:
objects.remove('')
self.assertEqual(r.status_code, 200)
self.assertTrue(oname in objects)
(self.assertTrue(o not in objects) for o in o_names[1:])
self.assertEqual(objects, l)
# test folder inheritance
oname, _ = self.create_folder(cname, HTTP_X_OBJECT_PUBLIC='true')
folder, _ = self.create_folder(cname, HTTP_X_OBJECT_PUBLIC='true')
# create child object
descendant = '%s/%s' % (oname, get_random_name())
descendant = '%s/%s' % (folder, get_random_name())
self.upload_object(cname, descendant)
# request public
r = self.get('%s?shared=&public=' % container_url)
......@@ -422,7 +488,7 @@ class ContainerGet(PithosAPITest):
objects = r.content.split('\n')
if '' in objects:
objects.remove('')
self.assertTrue(oname in objects)
self.assertTrue(folder in objects)
self.assertTrue(descendant not in objects)
def test_list_objects(self):
......
snf-pithos-backend/pithos/backends/lib/sqlalchemy/node.py
View file @ bf5cd5c4
......@@ -765,7 +765,7 @@ class Node(DBWorker):
return None
def version_lookup_bulk(self, nodes, before=inf, cluster=0,
all_props=True):
all_props=True, order_by_path=False):
"""Lookup the current versions of the given nodes.
Return a list with their properties:
(serial, node, hash, size, type, source, mtime, muser, uuid,
......@@ -774,6 +774,7 @@ class Node(DBWorker):
if not nodes:
return ()
v = self.versions.alias('v')
n = self.nodes.alias('n')
if not all_props:
s = select([v.c.serial])
else:
......@@ -791,7 +792,11 @@ class Node(DBWorker):
self.nodes.c.node.in_(nodes))
s = s.where(and_(v.c.serial.in_(c),
v.c.cluster == cluster))
s = s.order_by(v.c.node)
if order_by_path:
s = s.where(v.c.node == n.c.node)
s = s.order_by(n.c.path)
else:
s = s.order_by(v.c.node)
r = self.conn.execute(s)
rproxy = r.fetchall()
r.close()
......
snf-pithos-backend/pithos/backends/lib/sqlite/node.py
View file @ bf5cd5c4
......@@ -624,7 +624,7 @@ class Node(DBWorker):
return None
def version_lookup_bulk(self, nodes, before=inf, cluster=0,
all_props=True):
all_props=True, order_by_path=False):
"""Lookup the current versions of the given nodes.
Return a list with their properties:
(serial, node, hash, size, type, source, mtime, muser, uuid,
......@@ -634,18 +634,19 @@ class Node(DBWorker):
if not nodes:
return ()
q = ("select %s "
"from versions "
"from versions v, nodes n "
"where serial in %s "
"and cluster = ? %s")
"and v.node = n.node "
"and cluster = ? %s ")
subq, args = self._construct_latest_versions_subquery(
nodes=nodes, before=before)
if not all_props:
q = q % ("serial", subq, '')
else:
q = q % (("serial, node, hash, size, type, source, mtime, muser, "
"uuid, checksum, cluster"),
q = q % (("serial, v.node, hash, size, type, source, mtime, "
"muser, uuid, checksum, cluster"),
subq,
'order by node')
"order by path" if order_by_path else "")
args += [cluster]
self.execute(q, args)
......
snf-pithos-backend/pithos/backends/modular.py
View file @ bf5cd5c4
......@@ -763,7 +763,7 @@ class ModularBackend(BaseBackend):
paths = [x[len(cont_prefix):] for x in paths]
objects = [(p,) + props for p, props in
zip(paths, self.node.version_lookup_bulk(
nodes, all_props=all_props))]
nodes, all_props=all_props, order_by_path=True))]
return objects
def _list_objects_no_limit(self, user, account, container, prefix,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment