Commit bde4228b authored by Christos Stavrakakis's avatar Christos Stavrakakis
Browse files

Issue commission when deleting VM/Network

Issue commission to the Quotaholder when being notified from the Ganeti
backend that a VM/Network has been deleted. Although the resource has
already been deleting, we are interacting with the quotaholder in a
two step phase: issue commission and accept commission. It would be
better to merge these two steps into one.
parent e9b3acd4
......@@ -42,6 +42,7 @@ from synnefo.db.models import (Backend, VirtualMachine, Network,
pooled_rapi_client, BridgePoolTable,
MacPrefixPoolTable, VirtualMachineDiagnostic)
from synnefo.logic import utils
from synnefo import quotas
from logging import getLogger
log = getLogger(__name__)
......@@ -55,8 +56,9 @@ _firewall_tags = {
_reverse_tags = dict((v.split(':')[3], k) for k, v in _firewall_tags.items())
def process_op_status(vm, etime, jobid, opcode, status, logmsg):
def process_op_status(serials, vm, etime, jobid, opcode, status, logmsg):
"""Process a job progress notification from the backend
Process an incoming message from the backend (currently Ganeti).
......@@ -79,13 +81,11 @@ def process_op_status(vm, etime, jobid, opcode, status, logmsg):
if status == 'success' and state_for_success is not None:
vm.operstate = state_for_success
# Special case: if OP_INSTANCE_CREATE fails --> ERROR
if status in ('canceled', 'error') and opcode == 'OP_INSTANCE_CREATE':
if opcode == 'OP_INSTANCE_CREATE' and status in ('canceled', 'error'):
vm.operstate = 'ERROR'
vm.backendtime = etime
if opcode == 'OP_INSTANCE_REMOVE':
elif opcode == 'OP_INSTANCE_REMOVE':
# Set the deleted flag explicitly, cater for admin-initiated removals
# Special case: OP_INSTANCE_REMOVE fails for machines in ERROR,
# when no instance exists at the Ganeti backend.
......@@ -93,6 +93,13 @@ def process_op_status(vm, etime, jobid, opcode, status, logmsg):
if status == 'success' or (status == 'error' and
vm.operstate == 'ERROR'):
# Issue commission
serial = quotas.issue_vm_commission(vm.userid, vm.flavor,
vm.serial = serial
serial.accepted = True
vm.deleted = True
......@@ -230,6 +237,45 @@ def process_network_status(back_network, etime, jobid, opcode, status, logmsg):
def update_network_state(serials, network):
old_state = network.state
backend_states = [s.operstate for s in network.backend_networks.all()]
if not backend_states:
network.state = 'PENDING'
all_equal = len(set(backend_states)) <= 1
network.state = all_equal and backend_states[0] or 'PENDING'
# Release the resources on the deletion of the Network
if old_state != 'DELETED' and network.state == 'DELETED':"Network %r deleted. Releasing link %r mac_prefix %r",, network.mac_prefix,
network.deleted = True
if network.mac_prefix and network.type == 'PRIVATE_MAC_FILTERED':
mac_pool = MacPrefixPoolTable.get_pool()
if and network.type == 'PRIVATE_VLAN':
bridge_pool = BridgePoolTable.get_pool()
# Issue commission
serial = quotas.issue_network_commission(network.userid, delete=True)
network.serial = serial
serial.accepted = True
def process_network_modify(back_network, etime, jobid, opcode, status,
add_reserved_ips, remove_reserved_ips):
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment