From 928e4359460efc29833eb8371262c9a61b2bef85 Mon Sep 17 00:00:00 2001 From: Giorgos Korfiatis Date: Wed, 5 Feb 2014 14:28:37 +0200 Subject: [PATCH] snf_django: Fix select_related in ListCommand Pass all related fields in a single call, because select_related does not chain as expected (yet). See https://code.djangoproject.com/ticket/16855 Also pass prefetch_related in a uniform way. --- snf-django-lib/snf_django/management/commands/__init__.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/snf-django-lib/snf_django/management/commands/__init__.py b/snf-django-lib/snf_django/management/commands/__init__.py index 2884d2116..42d0e66b9 100644 --- a/snf-django-lib/snf_django/management/commands/__init__.py +++ b/snf-django-lib/snf_django/management/commands/__init__.py @@ -250,10 +250,10 @@ class ListCommand(SynnefoCommand): objects = self.object_class.objects try: - for sr in select_related: - objects = objects.select_related(sr) - for pr in prefetch_related: - objects = objects.prefetch_related(pr) + if select_related: + objects = objects.select_related(*select_related) + if prefetch_related: + objects = objects.prefetch_related(*prefetch_related) objects = objects.filter(**self.filters) objects = objects.exclude(**self.excludes) except FieldError as e: -- GitLab