Commit 3d6a5fb4 authored by Christos Stavrakakis's avatar Christos Stavrakakis
Browse files

cyclades: Check qh resolve commission response

Check Quotaholder response to see if the commissions were accepted or
rejected as requested, or failed for some reason.

Accepting or rejecting a commission will fail if the commission was
already resolved. Since this is sometimes accepted, like when
reconciling commissions, this commit extends 'qh_resolve_commissions'
function with the 'strict' argument, denoting whether the function
should fail if resolving a commissions fails.
parent ba3d2d1f
......@@ -91,22 +91,30 @@ def issue_commission(user, source, provisions,
raise Exception("No serial")
def accept_commissions(accepted):
def accept_commissions(accepted, strict=True):
return qh_resolve_commissions(accept=accepted, strict=strict)
def reject_commissions(rejected):
def reject_commissions(rejected, strict=True):
return qh_resolve_commissions(reject=rejected, strict=strict)
def qh_resolve_commissions(accept=None, reject=None):
def qh_resolve_commissions(accept=None, reject=None, strict=True):
if accept is None:
accept = []
if reject is None:
reject = []
qh = Quotaholder.get()
qh.resolve_commissions(ASTAKOS_TOKEN, accept, reject)
response = qh.resolve_commissions(ASTAKOS_TOKEN, accept, reject)
if strict:
failed = response["failed"]
if failed:
log.error("Unexpected error while resolving commissions: %s",
return response
def fix_pending_commissions():
......@@ -197,9 +205,9 @@ def issue_and_accept_commission(resource, delete=False):
" '%s' is still pending." % (resource, previous_serial)
raise Exception(msg)
elif previous_serial.accept:
accept_commissions(accepted=[previous_serial.serial], strict=False)
reject_commissions(rejected=[previous_serial.serial], strict=False)
previous_serial.resolved = True
......@@ -63,8 +63,8 @@ class Command(BaseCommand):
if fix and (accepted or rejected):
self.stdout.write("Fixing pending commissions..\n")
quotas.resolve_commissions(accepted=accepted, rejected=rejected,
def list_to_string(l):
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment