Commit 0b1c6f02 authored by Giorgos Korfiatis's avatar Giorgos Korfiatis
Browse files

cyclades: Limit quota enforcement operations

Add option in enforce-resources-cyclades to specify the maximum number of
operations to perform per backend.

Also ensure that quota are always checked in the same order.
parent 83adf356
......@@ -100,7 +100,7 @@ def handle_stop_active(viol_id, resource, vms, diff, actions):
diff -= CHANGE[resource](vm)
if vm_actions.get( is None:
action = "REMOVE" if vm.operstate == "ERROR" else "SHUTDOWN"
vm_actions[] = viol_id, vm.operstate, action
vm_actions[] = viol_id, vm.operstate, vm.backend_id, action
def handle_destroy(viol_id, resource, vms, diff, actions):
......@@ -110,7 +110,7 @@ def handle_destroy(viol_id, resource, vms, diff, actions):
if diff < 1:
diff -= CHANGE[resource](vm)
vm_actions[] = viol_id, vm.operstate, "REMOVE"
vm_actions[] = viol_id, vm.operstate, vm.backend_id, "REMOVE"
def _state_after_action(vm, action):
......@@ -121,13 +121,19 @@ def _state_after_action(vm, action):
return vm.operstate # no action
def _maybe_action(tpl):
if tpl is None:
return None
return tpl[-1]
def sort_ips(vm_actions):
def f(ip):
if not ip.in_use():
level = 5
machine = ip.nic.machine
_, _, action = vm_actions.get(, (None, None, None))
action = _maybe_action(vm_actions.get(
level = VM_SORT_LEVEL[_state_after_action(machine, action)]
return (level,
return f
......@@ -142,7 +148,11 @@ def handle_floating_ip(viol_id, resource, ips, diff, actions):
diff -= CHANGE[resource](ip)
state = "USED" if ip.in_use() else "FREE"
ip_actions[] = viol_id, state, "REMOVE"
if ip.nic and ip.nic.machine:
backend_id = ip.nic.machine.backend_id
backend_id = None
ip_actions[] = viol_id, state, backend_id, "REMOVE"
def get_vms(users=None):
......@@ -186,10 +196,22 @@ def apply_to_vm(action, vm_id):
return False
def perform_vm_actions(actions, fix=False):
def allow_operation(backend_id, opcount, maxops):
if backend_id is None or maxops is None:
return True
backend_ops = opcount.get(backend_id, 0)
if backend_ops >= maxops:
return False
opcount[backend_id] = backend_ops + 1
return True
def perform_vm_actions(actions, opcount, maxops=None, fix=False):
log = []
for vm_id, (viol_id, state, vm_action) in actions.iteritems():
data = ("vm", vm_id, state, vm_action, viol_id)
for vm_id, (viol_id, state, backend_id, vm_action) in actions.iteritems():
if not allow_operation(backend_id, opcount, maxops):
data = ("vm", vm_id, state, backend_id, vm_action, viol_id)
if fix:
r = apply_to_vm(vm_action, vm_id)
data += ("DONE" if r else "FAILED",)
......@@ -225,10 +247,12 @@ def remove_ip(ip_id):
return False
def perform_floating_ip_actions(actions, fix=False):
def perform_floating_ip_actions(actions, opcount, maxops=None, fix=False):
log = []
for ip_id, (viol_id, state, ip_action) in actions.iteritems():
data = ("floating_ip", ip_id, state, ip_action, viol_id)
for ip_id, (viol_id, state, backend_id, ip_action) in actions.iteritems():
if not allow_operation(backend_id, opcount, maxops):
data = ("floating_ip", ip_id, state, backend_id, ip_action, viol_id)
if ip_action == "REMOVE":
if fix:
r = remove_ip(ip_id)
......@@ -237,16 +261,17 @@ def perform_floating_ip_actions(actions, fix=False):
return log
def perform_actions(actions, fix=False):
def perform_actions(actions, maxops=None, fix=False):
("floating_ip", perform_floating_ip_actions),
("vm", perform_vm_actions),
opcount = {}
logs = []
for resource_type, handler in ACTION_HANDLING:
t_actions = actions.get(resource_type, {})
log = handler(t_actions, fix=fix)
log = handler(t_actions, opcount, maxops=maxops, fix=fix)
logs += log
return logs
......@@ -35,6 +35,7 @@ import string
from optparse import make_option
from django.db import transaction
from synnefo.lib.ordereddict import OrderedDict
from synnefo.quotas import util
from synnefo.quotas import enforce
from synnefo.quotas import errors
......@@ -52,6 +53,8 @@ class Command(SynnefoCommand):
help = """Check and fix quota violations for Cyclades resources.
option_list = SynnefoCommand.option_list + (
help="Limit operations per backend."),
make_option("--users", dest="users",
help=("Enforce resources only for the specified list "
"of users, e.g uuid1,uuid2")),
......@@ -100,6 +103,13 @@ class Command(SynnefoCommand):
write = self.stderr.write
fix = options["fix"]
force = options["force"]
maxops = options["max_operations"]
if maxops is not None:
maxops = int(maxops)
except ValueError:
m = "Expected integer max operations."
raise CommandError(m)
users = options['users']
if users is not None:
......@@ -111,6 +121,7 @@ class Command(SynnefoCommand):
except errors.AstakosClientException as e:
raise CommandError(e)
qh_holdings = sorted(qh_holdings.items())
resources = set(h[0] for h in handlers)
dangerous = bool(resources.difference(DEFAULT_RESOURCES))
......@@ -119,10 +130,10 @@ class Command(SynnefoCommand):
viol_id = 0
for resource, handle_resource, resource_type in handlers:
if resource_type not in actions:
actions[resource_type] = {}
actions[resource_type] = OrderedDict()
actual_resources = enforce.get_actual_resources(resource_type,
for user, user_quota in qh_holdings.iteritems():
for user, user_quota in qh_holdings:
for source, source_quota in user_quota.iteritems():
qh = util.transform_quotas(source_quota)
......@@ -163,8 +174,8 @@ class Command(SynnefoCommand):
write("Applying actions. Please wait...\n")
title = "Applied Actions" if fix else "Suggested Actions"
log = enforce.perform_actions(actions, fix=fix)
headers = ("Type", "ID", "State", "Action", "Violation")
log = enforce.perform_actions(actions, maxops=maxops, fix=fix)
headers = ("Type", "ID", "State", "Backend", "Action", "Violation")
if fix:
headers += ("Result",)
pprint_table(self.stderr, log, headers,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment