GitLab

Use check_yes_no() to test if a boolean property is set.

Although the documentation states that to set a boolean image property
you need to assign the "yes" value to it, this function will accept
"yes", "true", 1, "on" and "set" in a case-insensitive way and reject
"no", "false", 0, "off" and "unset".

An empty or not-set variable is treated as false.

An unknown value will raise a warning but will be accepted. This is done
to protect the users because prior to this commit, in some cases we only
tested if an image property had a non-empty value.

This resolves #80

Use heuristic methods to detect mandatory image properties if missing.

This resolves #50

If no image properties are defined, then do not run any configuration
task. Prior to this commit, the system would fail if no image
properties were present.

 * Fix various spelling errors
 * Add module comments on all python utilities

Resizing NetBSD and OpenBSD partitions, as well as FFS filesystems
does not work for now

Fix a bug in get_partition_to_resize where the script would not stop
if the get_partition_table function failed, leading to bash syntax
errors.

File injection isn't implemented yet

Check the cmdline of the kernel to determine what device to check
for find the rules file

Make sure everything works even when the root filesystem in the helper
VM is mounted read-only.

Make it comply with the rest of the software. Some things are not
ready yet.

If the image has /home on a different partition than /, then
we'll need to have it mounted to inject files on a user's home
directory.

Fix a bug where errors that where not created using log_error where
not registered to the monitoring subsystem.

In image helper, check if decode-properties.py returned 0 and log
the error if this is not the case.

Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>

Make snf-image-helper ran as init process when calling the helper
VM. Also make the helper VM shut down quickly by using the shut off
SysRq.

snf-image-helper by default uses it's own version of unattend.xml file,
but if UNATTEND variable is specified then it will use the one provided
by snf-image-host.

Fix a bug where the partition that should be resized in some cases
was computed in a wrong way

This is needed because common.sh contains functions that use pipes,
and the script should fail if any command fails.

Also did a minor cleanup in AssignHostname task

Image properties should be an optional argument. In any other case
snf-image does not retail backward compatibility.

Some files were accidentally left out from the last license and
copyright fix.

The should look like this: SNF_IMAGE_PROPERTY_<TASK_NAME>_TASK

* In decode-properties.py, use subprocess.Popen method instead of
  subprocess.check_output, which is introduced in python 2.7

* Fix a bug in snf-image-helper where decode-properties.py was not
  properly called

* Fix a bug in FixPartitionTable task

Prepend a timestamp before every line of output of run-parts hooks,
needed as a quick-n-dirty way to estimate the time taken by each hook to
complete.

Refs #1499

Make sure snf-image-host passes the magic argument
in the kernel command line of the helper VM to activate snf-image-helper,
update AUTHORS.

Only activate the snf-image-helper automatically if the caller
has passed a magic argument in the kernel command line.

Require a '--force' argument to activate snf-image-helper,
to avoid accidental execution of the script.

 * Make all "local" variables lowercase.
 * Move HELPER_EXTRA_PKGS from snf-image-update-helper to common.sh
 * Protect all variables from spaces and other special chars
 * Remove extra X's from mktemp template names (only 6 are supported).
 * Make sure pipelines fail if any command (not only the rightmost)
   fails

Since the mount and umount commands are tasks, if a task fails, the
filesystem may have been left mounted. For this case, I've created a
trap that tries to umount the filesystem