GitLab

For {ext,ntfs}dump this is always 1.
For diskdump this is an image property

Also remove `-l' option. It's no longer needed.

Prepend a timestamp before every line of output of run-parts hooks,
needed as a quick-n-dirty way to estimate the time taken by each hook to
complete.

Refs #1499

This has an affect on fedora and ubuntu instances, where user password
is not changed. Only the root one.

DeleteSShKeys task used to fail when /etc/ssh/sshd_config was missing.
We decided to relax this constraint and make it create warnings instead.

Fix usage of file as a var name, in personality task,
it's a built-in Python identifier.

The python code did not compile. File object was not created correct.

run-parts refuses to execute files with extensions.

Make sure snf-image-host passes the magic argument
in the kernel command line of the helper VM to activate snf-image-helper,
update AUTHORS.

Only activate the snf-image-helper automatically if the caller
has passed a magic argument in the kernel command line.

Require a '--force' argument to activate snf-image-helper,
to avoid accidental execution of the script.

This is really minor, but since we are using a bash var for losetup in
create, which is overwritable from the defaults file, lets keep it that
way.

 * Make all "local" variables lowercase.
 * Move HELPER_EXTRA_PKGS from snf-image-update-helper to common.sh
 * Protect all variables from spaces and other special chars
 * Remove extra X's from mktemp template names (only 6 are supported).
 * Make sure pipelines fail if any command (not only the rightmost)
   fails

Since the mount and umount commands are tasks, if a task fails, the
filesystem may have been left mounted. For this case, I've created a
trap that tries to umount the filesystem

Helper image should never have filesystem checks. The default rule mkfs
implies is to check every 24 mounts or 180 days.