Commit aa7ca650 authored by Klaus Aehlig's avatar Klaus Aehlig

Add a function to find a suitable secondary

On disk conversion to DRBD, a new secondary node has to be found.
Add a function doing this search in a way similar to what instance
allocation does: all possible placements are considered and the
one resulting in the best cluster metrics is taken.

To have a uniform interface, use the same signature as all allocation
functions, even though the group list is not needed (we have to take
the group of the primary node anyway).
Signed-off-by: default avatarKlaus Aehlig <aehlig@google.com>
Reviewed-by: default avatarHelga Velroyen <helgav@google.com>
parent 0c2f58bb
......@@ -909,6 +909,7 @@ HS_LIB_SRCS = \
src/Ganeti/HTools/Backend/Text.hs \
src/Ganeti/HTools/CLI.hs \
src/Ganeti/HTools/Cluster.hs \
src/Ganeti/HTools/Cluster/AllocateSecondary.hs \
src/Ganeti/HTools/Cluster/AllocationSolution.hs \
src/Ganeti/HTools/Cluster/Evacuate.hs \
src/Ganeti/HTools/Cluster/Metrics.hs \
......
{-| Implementation of finding a secondary for disk template conversion
-}
{-
Copyright (C) 2015 Google Inc.
All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:
1. Redistributions of source code must retain the above copyright notice,
this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-}
module Ganeti.HTools.Cluster.AllocateSecondary
( tryAllocateSecondary
) where
import Control.Monad (unless)
import Ganeti.BasicTypes
import Ganeti.HTools.AlgorithmParams (AlgorithmOptions(..))
import qualified Ganeti.HTools.Cluster as Cluster
import Ganeti.HTools.Cluster.AllocationSolution (AllocSolution)
import qualified Ganeti.HTools.Container as Container
import qualified Ganeti.HTools.Group as Group
import qualified Ganeti.HTools.Instance as Instance
import qualified Ganeti.HTools.Node as Node
import Ganeti.HTools.Types
tryAllocateSecondary :: AlgorithmOptions
-> Group.List -- ^ The cluster groups
-> Node.List -- ^ The node list (cluster-wide,
-- not per group)
-> Instance.List -- ^ Instance list (cluster-wide)
-> Idx
-> Result AllocSolution
tryAllocateSecondary opts _ nl il idx = do
let inst = Container.find idx il
unless (Instance.sNode inst < 0)
$ fail "Instance already has a secondary"
let pidx = Instance.pNode inst
pnode = Container.find pidx nl
pnode' = Node.removePri pnode inst
nl' = Container.add pidx pnode' nl
inst' = inst { Instance.diskTemplate = DTDrbd8 }
gidx = Node.group pnode'
sidxs = filter (/= pidx) . Container.keys
$ Container.filter ((==) gidx . Node.group) nl'
Cluster.tryAlloc opts nl' il inst' $ Right [(pidx, sidxs)]
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment