1. 07 Jun, 2011 2 commits
  2. 01 Jun, 2011 4 commits
  3. 31 May, 2011 6 commits
  4. 30 May, 2011 3 commits
    • Michael Hanselmann's avatar
      gnt-node migrate: Use LU-generated jobs · b7a1c816
      Michael Hanselmann authored
      
      
      Until now LUNodeMigrate used multiple tasklets to evacuate all primary
      instances on a node. In some cases it would acquire all node locks,
      which isn't good on big clusters. With upcoming improvements to the LUs
      for instance failover and migration, switching to separate jobs looks
      like a better option. This patch changes LUNodeMigrate to use
      LU-generated jobs.
      
      While working on this patch, I identified a race condition in
      LUNodeMigrate.ExpandNames. A node's instances were retrieved without a
      lock and no verification was done.
      
      For RAPI, a new feature string is added and can be used to detect
      clusters which support more parameters for node migration. The client
      is updated.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      b7a1c816
    • Apollon Oikonomopoulos's avatar
      Fix argument order in ReserveLV and ReserveMAC · 8785b71b
      Apollon Oikonomopoulos authored
      
      
      ConfigWriter.ReserveLV() and Configwriter.ReserveMAC() called
      TemporaryReservationManager.Reserve() with the ec_id and resource arguments
      swapped. As a result, two reservation attempts for the same resource type
      within the same LU would fail, even if the resources requested were different,
      e.g.:
      
        $ gnt-instance add -t sharedfile -o debootstrap+default \
             --net 0:mac=00:01:02:03:04:00 \
             --net 1:mac=00:01:02:03:04:ff \
             --disk 0:size=2g  test_instance
        Failure: prerequisites not met for this operation:
        error type: resource_not_unique, error details:
        MAC address 00:01:02:03:04:ff already in use in cluster
      
      This patch fixes the argument order in the call to Reserve().
      Signed-off-by: default avatarApollon Oikonomopoulos <apollon@noc.grnet.gr>
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      8785b71b
    • Michael Hanselmann's avatar
      ht: Accept both int and long as integers · b99b607f
      Michael Hanselmann authored
      
      
      This fixes a unittest failure on 32 bit systems. A recently added
      unittest for ht.TJobId uses a rather large number (2347625220). On 64
      bit systems it is stored as “int”. On 32 bit systems however, Python
      uses “long”. The two types can be intermixed in Python as the
      interpreter will take care of conversions. If one processed too many
      jobs (2**31) on a 32 bit system, ht would no longer accept the job IDs.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      b99b607f
  5. 27 May, 2011 1 commit
  6. 26 May, 2011 1 commit
    • Michael Hanselmann's avatar
      TLReplaceDisks: Move assertion checking locks · a9b42993
      Michael Hanselmann authored
      Commit 1bee66f3
      
       added assertions for ensuring only the necessary locks
      are kept while replacing disks. One of them makes sure locks have been
      released during the operation. Unfortunately the commit added the check
      as part of a “finally” branch, which is also run when an exception is
      thrown (in which case the locks may not have been released yet). Errors
      could be masked by the assertion error. Moving the check out of the
      “finally” branch fixes the issue.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      a9b42993
  7. 25 May, 2011 4 commits
  8. 24 May, 2011 7 commits
  9. 20 May, 2011 12 commits