GitLab

The original version accidentally used `Map.update` instead of
`Map.alter`, which broke insertions (the function would only have
an effect if the key was already in the container).
Signed-off-by: Niklas Hambuechen <niklash@google.com>
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

Mention inherited changes as well as the fixes made to
stable-2.12 since beta1.
Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

When, at cluster init, checking for left overs of a previous
cluster, only look for spurious files. This will the directory
structure to be set up ahead of time.
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Petr Pudlak <pudlak@google.com>

* stable-2.11
  (no changes)

* stable-2.10
  Fix network info in case of multi NIC instances
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Petr Pudlak <pudlak@google.com>

Since 'jessie' isn't in the debootstrap list yet, we need to use the
name 'testing'. Nevertheless, it always makes sense to test the project
against the upcoming Debial release.
Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

- Don't explicitly install virtual packages provided by GHC
  (and note this in the list).
- Add minimum versions to several packages.
- Fix the configuration flag for the monitoring daemon.
- Add a note that additional packages installed using cabal should go
  only after the ones provided by the user's distribution.
Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

As of attoparsec 0.12 the main module is deprecated, which causes the
build to fail. Therefore import the same attoparsec sub-module that is
used by other Ganeti modules.
Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

* stable-2.10
  Fix network info in case of multi NIC instances

Conflicts:
	lib/cmdlib/network.py: use stable-2.11 version
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Petr Pudlak <pudlak@google.com>

Network query mechanism fills inst_list field with the list of
instances that are connected to the corresponding network.
Fix the case of multi NIC instances where the NIC scan stopped
once a matching network was found.
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

.. in "replace-disks", as starting the disks changes the instance object
and a subsequent call to cfg.Update fails.
Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

The only problem was that at the end of the operation, the check for
deactivating the disks was too strict, requiring that the instance is
DOWN. This relaxes the check to allow OFFLINE as well.
Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

A new Ganeti cluster should not inherit state from a previously existing
cluster. Therefore, on cluster initialization, verify that no dangerous
left-overs are present in the DATA_DIR. We cannot, however, insist on
the DATA_DIR being completely empty, as it is good practice to set up
the rapi user file ahead of time. What we therefore do is to verify
that
- the DATA_DIR, if present, only contains directory entries, and
- the QUEUE_DIR, if present, is empty.
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Petr Pudlak <pudlak@google.com>

While the old description ("The file should contain text data,
line-based, with single empty lines separating sections. The
lines themselves are column-based, with the pipe symbol (|) acting
as separator.") is precise and unambiguous, we did have some
misunderstandings in the past. So add the format of the empty
section (which makes sense to describe a cluster without any
instances) as a clarifying example.
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Petr Pudlak <pudlak@google.com>

* stable-2.11
  Fix invalid use of RpcResult.Raise
  Bump revision to 2.11.5
  Prepare NEWS file for 2.11.5 release

* stable-2.10
  On upgrades, check for upgrades to resume first
  Pause watcher during upgrade
  Allow instance disks to be added with --no-wait-for-sync
  Bump revision to 2.10.7
  Prepare NEWS file for 2.10.7 release
  Fix lint error
  Create the config backup archive in a safe way

Conflicts:
	NEWS: take ALL the entries
	configure.ac: ignore revision bump
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Petr Pudlak <pudlak@google.com>

* stable-2.10
  On upgrades, check for upgrades to resume first
  Pause watcher during upgrade
  Allow instance disks to be added with --no-wait-for-sync
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Petr Pudlak <pudlak@google.com>

Make gnt-cluster upgrade refuse to upgrade if an upgrade to be resumed
is present. For the convenience of the user, consider an upgrade
command to the same target version as the upgrade to be resumed as an
equivalent way of saying that the pending upgrade is to be resumed.
Fixes issue 906.
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>

As also suggested in the manual upgrade instructions,
pause the watcher (for 1h) during the upgrade. Fixes
issue 905.
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>

Fix statements which using result.Raise in invalid form.
Change comma to '%' operator to provide a formatted string as these
lines originally expected.
Signed-off-by: Yuto KAWAMURA(kawamuray) <kawamuray.dadada@gmail.com>
Reviewed-by: Helga Velroyen <helgav@google.com>

The patch 3c260845

 fixed a bug where
adding a new disk to an instance with deactivated disks activated the
disk. However, it also introduced some erroneous behaviour, preventing
disks from being added to online instances with --no-wait-for-sync.

In line with the original meaning of the patch, this patch modifies the
check to disallow adding disks to shutdown instances with
--no-wait-for-sync, and allow doing so for online instances.
Signed-off-by: Hrvoje Ribicic <riba@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Hrvoje Ribicic <riba@google.com>

Basically inheriting everything from 2.10.7.
Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Hrvoje Ribicic <riba@google.com>

Conflicts:
	NEWS
	configure.ac

Resolutions:
  NEWS: add NEWS entry for 2.10.7
  configure.ac: keep 2.11.4 as version number
Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>

Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Michele Tartara <mtartara@google.com>

Note the security issue with config backups
and other changes.
Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Michele Tartara <mtartara@google.com>

This fixes a lint error of the previous patch complaining
about an unused variable.
Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Michele Tartara <mtartara@google.com>

Since the config backup archive contains sensitive information and is
written in world-readable locations (/var/lib by default), it should be
created in a safe way and with strict permissions.

This commit uses a temporary file to tackle two issues: the relaxed
permissions of the archive which respected the umask of the user running
`gnt-cluster upgrade' and a (possible) collision attack using a
pre-created file with the predictable backup filename.
Signed-off-by: Apollon Oikonomopoulos <apoikos@gmail.com>
Reviewed-by: Helga Velroyen <helgav@google.com>

It only needs to be explicitly enabled in KVM hypervisor parameters, for
Xen it works out of the box.
Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Hrvoje Ribicic <riba@google.com>

* stable-2.11
  Postpone release of 2.11.4 by one day
  Remove known issues section for 2.11.4
  Add known issue to 2.11.4 NEWS file
  Bump version to 2.11.4
  Prepare NEWS file for 2.11.4

* stable-2.10
  Add non-cherry-pickable changes related to state "rb----"
  Add Xen nothing state '------'
  Add Xen paused state as a Ganeti running state
  Update usage string for 'gnt-network connect'

Conflicts:
	NEWS
	configure.ac
	lib/hypervisor/hv_xen.py
Resolution:
  NEWS - include additions from 2.11
  configure.ac - keep the 2.12 version
  lib/hypervisor/hv_xen.py - keep enhanced comments from 2.11
Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>

Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Hrvoje Ribicic <riba@google.com>

As we will postpone the release for tomorrow, the bug will
be fixed in the release.
Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Hrvoje Ribicic <riba@google.com>

From stable-2.10:
  Add non-cherry-pickable changes related to state "rb----"
  Add Xen nothing state '------'
  Add Xen paused state as a Ganeti running state
  Update usage string for 'gnt-network connect'

Conflicts:
	lib/hypervisor/hv_xen.py - Taken the more complete 2.10 version
Signed-off-by: Hrvoje Ribicic <riba@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>

Ganeti versions 2.11 and 2.12 have both had patches related to strange
Xen domU states which are still legitimate running states, but Ganeti
did not recognize them as such. The previous two cherry-picked patches
bring some of these changes, but the final patch needed (79cb7ece

)
cannot be cherry-picked because of a conflict with the other two
patches. The changes were made on different branches, and merged
together at a later time.

This patch manually adds the change, merging together the descriptions
of why certain states are allowed, and putting all of this into the
function docstring.
Signed-off-by: Hrvoje Ribicic <riba@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>

... which means that a domain is in the queue behind other domains
waiting to be scheduled.  The domain is runnable but it is not
currently running.
Signed-off-by: Jose A. Lopes <jabolopes@google.com>
Reviewed-by: Hrvoje Ribicic <riba@google.com>

Cherry-picked from 30350df5

.
Signed-off-by: Hrvoje Ribicic <riba@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>

The QA test 'TestClusterBurnin' pauses instances and the Xen state
domain 'paused' was not being handled properly by Ganeti because it
was not being classified as either a running or shutdown state.  This
patch adds the 'paused' state to the set of running states by
extending the function 'ganeti.hypervisor.hv_xen._IsInstanceRunning'
with the corresponding Xen state string '--p---'.

This fixes the QA test 'TestClusterBurnin'.
Signed-off-by: Jose A. Lopes <jabolopes@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>

Cherry-picked from fd201010

.
Signed-off-by: Hrvoje Ribicic <riba@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>

Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Hrvoje Ribicic <riba@google.com>

Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Hrvoje Ribicic <riba@google.com>

Add the developments since 2.11.3.
Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Hrvoje Ribicic <riba@google.com>

The problem is that (at least) GHC 7.6.3 has a bug that leaks memory for
'handleToFd' calls. Hence as a workaround we open the file again using
just 'openFd'. The additional benefit is that it also works if the file
has been already close.
Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>

On some architectures 'openTempFile' converts new-line symbols.
While the difference probably manifests only on Windows machines, we
should use the proper semantics anyway.
Signed-off-by: Petr Pudlak <pudlak@google.com>
Reviewed-by: Klaus Aehlig <aehlig@google.com>