1. 07 Oct, 2014 1 commit
  2. 26 Sep, 2014 1 commit
    • Niklas Hambuechen's avatar
      design-optables: Fix maintenance pause example · 06710954
      Niklas Hambuechen authored
      The example filter did not actually do what was written in its description.
      
      For `reason` predicates, the spec says
      
          "This predicate is true, if one of the entries of one of the opcodes
          in this job satisfies the expression."
      
      The existing
      
          ["reason", ["!", ["=~", "reason", "maintenance pink bunny"]]]
      
      would therefore match on pretty much all jobs submitted, as even
      jobs with `--reason="maintenance pink bunny"` have other reason trail
      entries that are not "maintenance pink bunny", and one such entry
      suffices to satisfy the expression. Consequenlty, the given example
      would in practice pause all new jobs.
      
      The correct way to do this is a filter chain:
      
          prio 0  ["reason", ["=~", "reason", "maintenance pink bunny"]]  PASS
          prio 1  ["jobid", [">", "id", "watermark"]]                     PAUSE
      Signed-off-by: default avatarNiklas Hambuechen <niklash@google.com>
      Signed-off-by: default avatarKlaus Aehlig <aehlig@google.com>
      Reviewed-by: default avatarKlaus Aehlig <aehlig@google.com>
      06710954
  3. 23 Sep, 2014 1 commit
  4. 15 Sep, 2014 2 commits
  5. 17 Jul, 2014 1 commit
  6. 08 Jul, 2014 1 commit
  7. 24 Jul, 2013 1 commit