1. 29 Apr, 2013 1 commit
  2. 24 Apr, 2013 1 commit
  3. 04 Apr, 2013 1 commit
  4. 26 Mar, 2013 2 commits
  5. 27 Feb, 2013 2 commits
  6. 12 Feb, 2013 1 commit
  7. 11 Feb, 2013 2 commits
  8. 08 Feb, 2013 1 commit
  9. 05 Feb, 2013 3 commits
  10. 31 Jan, 2013 1 commit
  11. 24 Jan, 2013 1 commit
  12. 11 Jan, 2013 1 commit
  13. 19 Dec, 2012 1 commit
    • Iustin Pop's avatar
      Remove some unused Python code · 45317e3a
      Iustin Pop authored
      This patch removes code which is no longer used due to refactoring:
      
      - http.InitSsl, last usage removed in commit 33231500 (“Convert RPC
        client to PycURL”)
      - rapi.baserlib.MakeParamsDict, last usage remove in commit 4e5a68f8
        (“RAPI: rlib1 removal”)
      - rapi.baserlib.ExtractField, last usage removed in commit 028c6b76
        (“RAPI:Fix root list and unittest for it.”)
      - qa.qa_utils.AssertNotEqual, last real usage removed in commit
        2f4b4f78 (“Simplify QA commands”) (but it was still imported for a
        while, until we extended pylint to run over the QA code as well)
      - qlang._IsHostname, added in commit f8638e28 (“Detect globbing
        patterns as query arguments”) but never used
      - cmdlib._BuildNetworkHookEnvByObject, last usage removed in commit
        f22433c0
      
       (“Locking related fixes for networks”)
      - NLD constants, which are obsolete—the nbma project is no longer
        maintained and it's not working with current ganeti
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      45317e3a
  14. 18 Dec, 2012 1 commit
  15. 11 Oct, 2012 1 commit
  16. 05 Jun, 2012 2 commits
    • Iustin Pop's avatar
      QA: stop logging SSH arguments for each invocation · 710bc88c
      Iustin Pop authored
      
      
      Currently, this is how the QA log looks like:
      
      Command: ssh -oEscapeChar=none -oBatchMode=yes -l root -t -oStrictHostKeyChecking=yes -oClearAllForwardings=yes -oForwardAgent=yes -oControlPath=/tmp/ganeti-qa-multiplexer.DMzkuH -oControlMaster=no node14 exit
      Command: ssh -oEscapeChar=none -oBatchMode=yes -l root -t -oStrictHostKeyChecking=yes -oClearAllForwardings=yes -oForwardAgent=yes node8 exit
      Command: ssh -oEscapeChar=none -oBatchMode=yes -l root -t -oStrictHostKeyChecking=yes -oClearAllForwardings=yes -oForwardAgent=yes node18 exit
      
      And these arguments are repeated over and over. This patch proposes to
      log once the arguments, at the beginning of the QA (so that the SSH
      commands can be reproduced, if needed) and then drop them from the
      log. The new output looks like:
      
      SSH command for primary node: ssh -oEscapeChar=none -oBatchMode=yes -lroot -oStrictHostKeyChecking=yes -oClearAllForwardings=yes -oForwardAgent=yes -oControlPath=/tmp/ganeti-qa-multiplexer.24lgrK -oControlMaster=no node14
      SSH command for other nodes: ssh -oEscapeChar=none -oBatchMode=yes -lroot -oStrictHostKeyChecking=yes -oClearAllForwardings=yes -oForwardAgent=yes NODE
      (the above are the informational messages about parameters, then)
      Command: ssh node14 exit
      Command: ssh node8 exit
      Command: ssh node18 exit
      
      This makes the QA log much more readable, by dropping unneeded clutter
      (look how long the original lines were), and hopefully also a bit
      smaller (current QA log is > 100MB of text output).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarBernardo Dal Seno <bdalseno@google.com>
      710bc88c
    • Iustin Pop's avatar
      Switch QA to tty-less mode · f14a8b15
      Iustin Pop authored
      
      
      This makes ssh generate much less noise when QA is run itself without
      a tty, as otherwise we get thousands of lines of:
      
        Pseudo-terminal will not be allocated because stdin is not a terminal.
      
      in the QA logs (which are already big enough).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      f14a8b15
  17. 15 May, 2012 1 commit
  18. 14 May, 2012 1 commit
  19. 10 May, 2012 1 commit
  20. 19 Apr, 2012 1 commit
  21. 13 Apr, 2012 1 commit
  22. 19 Jan, 2012 1 commit
  23. 30 Aug, 2011 1 commit
  24. 25 Jul, 2011 1 commit
  25. 08 Mar, 2011 1 commit
  26. 03 Mar, 2011 1 commit
    • René Nussbaumer's avatar
      LUInstanceRename: Fail if renamed hostname mismatch · 31fe5102
      René Nussbaumer authored
      
      
      There's a problem if you run gnt-instance rename with a non FQDN and the
      renamed LU tries to resolve the hostname to make it FQDN. It could be
      that this resolved hostname was just a CNAME to another name which leads
      to wrongly renamed instances name.
      
      Given a name of "foobar" is a CNAME to "moohost" now if you gonna rewrite an
      instance named "foobar1" to "foobar" it will pickup the host "moohost".
      This is not obvious behaviour. If we detect this case we abort with a
      prereq error. The user then however can continue with a FQDN and
      --no-name-check if he intends to force the operation.
      Signed-off-by: default avatarRené Nussbaumer <rn@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      31fe5102
  27. 03 Feb, 2011 1 commit
  28. 12 Jan, 2011 2 commits
    • Iustin Pop's avatar
      Run pylint over QA code too · 3582eef6
      Iustin Pop authored
      
      
      Right now, the QA code is not covered by pylint, and this shows at
      least one low-impact bug.
      
      This patch does the necessary changes to make QA pylint-clean, and the
      changes the makefile to run pylint for it.
      
      Notable changes:
      
      - qa_utils.GenericQueryTest: randfields was not used at all, and my
        belief is that it was indented to be used in order not to modify the
        input list; so I replaced randfields with fields, so we only shuffle
        the our local copy
      - qa_node.TestOutOfBand was using it's own copy of AcquireNode(), so I
        replaced it with the existing version
      - qa_os: was using 'dir' in a couple of places, replaced with dirname
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      3582eef6
    • Iustin Pop's avatar
      QA: use a persistent SSH connection to the master · f7e6f3c8
      Iustin Pop authored
      
      
      The recent additions to QA (many more tests) make QA slow if the
      machine on which the QA runs is not very close to the tested nodes —
      or in general, when the SSH handhaske is costly.
      
      We discussed before about using a persistent connection, and here is
      the patch that implements it. On a very small QA (very very small), it
      cuts down a lot of time (almost half), so it should be useful even for
      a full QA.
      
      I've also thought about changing from external ssh to paramiko, but I
      estimated that it would be more work to correctly interleave the IO
      from the remote process than just running a background SSH.
      
      Also note that yes, the global dict is ugly, but I don't know of
      another simple way to implement this.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      f7e6f3c8
  29. 10 Jan, 2011 1 commit
  30. 21 Dec, 2010 1 commit
  31. 16 Dec, 2010 1 commit
  32. 14 Dec, 2010 1 commit
  33. 10 Dec, 2010 1 commit