1. 17 Feb, 2011 4 commits
  2. 16 Feb, 2011 1 commit
  3. 15 Feb, 2011 1 commit
  4. 10 Feb, 2011 1 commit
  5. 09 Feb, 2011 3 commits
    • Iustin Pop's avatar
      Fix error msg for instances on offline nodes · 11dcce87
      Iustin Pop authored
      
      
      Currently, for both primary and secondary offline nodes, we give the
      same message:
      - ERROR: instance instance14: instance lives on offline node(s) node3
      - ERROR: instance instance15: instance lives on offline node(s) node3
      - ERROR: instance instance16: instance lives on offline node(s) node3
      - ERROR: instance instance17: instance lives on offline node(s) node3
      
      This is confusing, as an offline primary is in a different category
      than a secondary. The patch changes the warnings to have different
      error messages:
      - ERROR: instance instance14: instance has offline secondary node(s) node3
      - ERROR: instance instance15: instance has offline secondary node(s) node3
      - ERROR: instance instance16: instance lives on offline node node3
      - ERROR: instance instance17: instance lives on offline node node3
      
      Thanks to Alexander Schreiber <als@google.com> for reporting this
      issue.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAlexander Schreiber <als@google.com>
      11dcce87
    • Iustin Pop's avatar
      cluster verify and instance disks on offline nodes · a3de2ae7
      Iustin Pop authored
      
      
      Currently, cluster-verify says:
      
      - ERROR: instance instance14: couldn't retrieve status for disk/0 on node3: node offline
      - ERROR: instance instance14: instance lives on offline node(s) node3
      - ERROR: instance instance15: couldn't retrieve status for disk/0 on node3: node offline
      - ERROR: instance instance15: instance lives on offline node(s) node3
      
      This is redundant as the “lives on offline node” message should be all we need to
      understand the cluster situation.
      
      The patch fixes this and also corrects a very old idiom.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarStephen Shirley <diamond@google.com>
      a3de2ae7
    • Iustin Pop's avatar
      Cluster verify and N+1 warnings for offline nodes · f7661f6b
      Iustin Pop authored
      
      
      Currently, cluster verify shows warnings N+1 warnings for offline
      nodes having any redundant instances since the memory data that we
      have for those nodes is zero, so any instance will trigger the
      warning.
      
      As the comment says, we already list secondary instances on offline
      nodes, so that warning is enough, and we skip the N+1 one.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarStephen Shirley <diamond@google.com>
      f7661f6b
  6. 03 Feb, 2011 1 commit
  7. 01 Feb, 2011 2 commits
  8. 31 Jan, 2011 1 commit
  9. 28 Jan, 2011 4 commits
  10. 27 Jan, 2011 1 commit
    • Iustin Pop's avatar
      cluster verify: add hvparams verification · 58a59652
      Iustin Pop authored
      
      
      Currently, the validity of the hypervisor parameters is only checked
      at init/modification time, and not in the cluster verify. This is bad,
      as it can lead to inconsistent state that is only detected when the
      next modification (which can be unrelated) is made, leading to
      unexpected error messages.
      
      This patch adds both syntax verification (in masterd) and validity
      verification on remote nodes. The downside of the patch is that on
      clusters with many instances which have custom parameters, it will be
      slow. A possible improvement would be to detect duplicate, identical
      set of parameters, and collapse these into a single verification, but
      that is left as a TODO (in case it becomes problematic).
      
      An additional change is in utils.ForceDict, where we said 'key',
      whereas this function is always used with parameter dicts, so I
      changed it to "Unknown parameter".
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      58a59652
  11. 26 Jan, 2011 7 commits
  12. 24 Jan, 2011 1 commit
  13. 20 Jan, 2011 2 commits
  14. 19 Jan, 2011 1 commit
  15. 18 Jan, 2011 10 commits