1. 18 Mar, 2008 2 commits
    • Michael Hanselmann's avatar
      Move SSH functions into a class · c92b310a
      Michael Hanselmann authored
      This renames some functions and does some minor codestyle cleanup.
      
      Reviewed-by: ultrotter
      c92b310a
    • Michael Hanselmann's avatar
      Add function to write cluster SSH key to known_hosts file · 75a5f456
      Michael Hanselmann authored
      The whole Ganeti cluster has a single SSH key. Its fingerprint is
      written to Ganeti's known_hosts file, together with an alias. This
      allows us to always use that alias instead of the real hostname,
      making management of the known_hosts file much easier.
      
      This patch does not handle an upgrade from an earlier version.
      
      Reviewed-by: ultrotter
      75a5f456
  2. 19 Oct, 2007 1 commit
  3. 16 Oct, 2007 1 commit
    • Iustin Pop's avatar
      Replace more ssh paths with proper constants · 70d9e3d8
      Iustin Pop authored
      The node's ssh keys filenames are now provided as constants; this should
      allow easier customization.
      
      Also, the user's ssh key computing has been abstracted into ssh.py
      
      Reviewed-by: imsnah
      70d9e3d8
  4. 10 Oct, 2007 1 commit
    • Iustin Pop's avatar
      Remove the shebang from modules · 2f31098c
      Iustin Pop authored
      Since modules are not directly executables, remove the shebang from
      them. This helps with lintian warnings.
      
      Also make the autogenerated _autoconf.py contain two comment lines at
      the beginning, like the other modules.
      
      Reviewed-by: ultrotter
      2f31098c
  5. 13 Sep, 2007 1 commit
    • Iustin Pop's avatar
      Fix the ssh change which breaks remote ssh commands · 72f0f7fd
      Iustin Pop authored
      Explanation: since we use lists and not a string, every argument we give
      is passed unchanged to the remote shell. So, for example, passing
      '/etc/init.d/ganeti restart' to the remote shell, it will try to run the
      path /etc/init.d/ganeti\ restart. With the s space included. This
      breaks, for example, gnt-node add and gnt-cluster command.
      
      The original problem with the backup routines that led to the "'" change
      is that they use a plain " ".join(list), but we don't need to quote the
      whole ssh remote command for this. We can simply use the existing
      utils.ShellQuoteCmd(list) which does the proper quoting of the ';' or
      '&&' metacharacters.
      
      With this change, both gnt-node add, gnt-cluster command and
      export/import work.
      
      This also improves the error-handling behaviour of one cat command by
      making it conditional on the preceding mkdir.
      
      Reviewed-by: ultrotter
      72f0f7fd
  6. 07 Sep, 2007 1 commit
    • Guido Trotter's avatar
      Make import/export use the auxiliary ssh library to build the remote commands. · 00003458
      Guido Trotter authored
      This avoids forgetting some parameters, as it's happening right now 
      (the correct known host file is not being passed)
      
      In order to do so we split SSHCall into an auxiliary BuildSSHCmd which builds
      the command but doesn't actually call it, and SSHCall itself which runs RunCmd
      on top of BuildSSHCmd's result. BuildSSHCmd is then explicitely called by 
      import/export who has to build a more complex command to be run later.
      00003458
  7. 24 Aug, 2007 1 commit
    • Iustin Pop's avatar
      Rework ssh known-hosts handling. · 82122173
      Iustin Pop authored
      This changes:
        - cluster setup, we no longer edit /etc/ssh/ssh_known_hosts but our
          own file
        - node add, we no longer remove root's known_hosts (twice)
        - gnt-instance console, both the LU and the script: since now the ssh
          setup is not standard, we need to build the ssh cmdline in the LU
          (instead of manually building it in the script) with the correct
          parameters and use the command line as returned in the script
        - ssh.py, many changes, split options in module-level constants so
          that building the command line in different places is easier/more
          logical
        - backend.py, we no longer remove root's known_hosts in Add node, and
          we allow our own known_hosts file to be uploaded
      
      Reviewed-by: imsnah
      82122173
  8. 20 Aug, 2007 1 commit
    • Iustin Pop's avatar
      Disable hashing of the ssh keys. · 3899870e
      Iustin Pop authored
      In case we use StrictHostKeyChecking=ask, also add HashKnownHosts=no so that
      debugging is easier. The nodes to which we are connecting are anyway visible in
      /etc/ssh/ssh_known_hosts.
      3899870e
  9. 14 Aug, 2007 1 commit
    • Iustin Pop's avatar
      Style changes for pep-8 and python-3000 compliance. · 3ecf6786
      Iustin Pop authored
      This changes the raising of exceptions from:
        raise Exception, value
      to
        raise Exception(value)
      
      as the first form will be removed in python-3000 and the second form is
      preferred now.
      
      The changes also involve a few cases of changing from raising standard
      exceptions and use our own ones.
      
      The new version also fixes many pylint-generated warnings, especially in
      ganeti-noded where I changed many methods to @staticmethod.
      
      There is no functionality changed (barring any bugs).
      3ecf6786
  10. 26 Jul, 2007 1 commit
  11. 16 Jul, 2007 1 commit