1. 04 Feb, 2008 1 commit
  2. 31 Jan, 2008 1 commit
  3. 28 Jan, 2008 2 commits
  4. 20 Jan, 2008 2 commits
    • Iustin Pop's avatar
      Fix checking of node free disk in CreateInstance · 8d75db10
      Iustin Pop authored
      This patch does two things:
        - checks that the result values from call_node_info are valid integer
          values and aborts otherwise
        - skips disk space computation for the DT_DISKLESS case
      
      The most important point of the patch is the verification of results
      from the rpc call, as it prepares for a patch that allows failures to be
      better reported from the remote node.
      
      Reviewed-by: ultrotter
      8d75db10
    • Iustin Pop's avatar
      Abstract node memory checking into a separate function · d4f16fd9
      Iustin Pop authored
      The checking of a node's free memory (via rpc.call_node_info) is done in
      both start instance an failover. This patch abstracts this call,
      together with the appropriate error handling, into a separate function
      called _CheckNodeFreeMemory.
      
      The patch also has some related changes:
        - the check is done in prereq and not in exec for start instance
        - the redundant check in exec for failover has been removed
      
      Reviewed-by: ultrotter
      d4f16fd9
  5. 16 Jan, 2008 1 commit
  6. 14 Jan, 2008 2 commits
    • Iustin Pop's avatar
      Fix some misspellings · ba4b62cf
      Iustin Pop authored
      This patch fixes two name typos and a style issue (which makes pylint
      complain).
      
      Reviewed-by: ultrotter
      ba4b62cf
    • Guido Trotter's avatar
      Fix CreateInstance new optional parameters · 40ed12dd
      Guido Trotter authored
      Some new paramenters of the CreateInstance opcode are optional (namely
      kernel_path, initrd_path and hvm_boot_order) but their absence makes the code
      crash. Fix this by initializing them to a default value if they're not present.
      
      Reviewed-by: iustinp
      40ed12dd
  7. 11 Jan, 2008 1 commit
  8. 08 Jan, 2008 4 commits
  9. 07 Jan, 2008 1 commit
    • Iustin Pop's avatar
      Improve verify-disks: broken/missing LV detection · b63ed789
      Iustin Pop authored
      This patch improves the ‘gnt-cluster verify-disks’ command by adding
      support for detecting broken volume groups and missing logical volume
      names.
      
      As such, we don't try anymore to activate disks for instances that are
      not likely to succeed anyway, and instead report them.
      
      Reviewed-by: schreiberal
      b63ed789
  10. 27 Dec, 2007 1 commit
  11. 20 Dec, 2007 1 commit
  12. 18 Dec, 2007 3 commits
    • Alexander Schreiber's avatar
      Internal API change for instance console access. · 30989e69
      Alexander Schreiber authored
      Change the internal hypervisor API for GetShellCommandForConsole, we
      now call it with the instance instead of just the instance name.
      
      This is a prep patch for HVM, since HVM needs more than just the instance
      name to determine a way of console access.
      
      (this is a resend due to mail adress tyop)
      
      Reviewed-by: iustinp
      
      30989e69
    • Alexander Schreiber's avatar
      cleanup for hypervisor constants · 2584d4a4
      Alexander Schreiber authored
      Move constant definitions for hypervisor into constants.py
      
      Reviewed-by: ultrotter
      
      2584d4a4
    • Guido Trotter's avatar
      Specify hint as a named argument · 79caa9ed
      Guido Trotter authored
      hint is declared as a named argument for the LogWarning function. Make its
      caller pass it naming it.
      
      Reviewed-by: iustinp
      79caa9ed
  13. 17 Dec, 2007 1 commit
  14. 12 Dec, 2007 1 commit
    • Iustin Pop's avatar
      Add LUVerifyDisks · 2c95a8d4
      Iustin Pop authored
      This patch adds a new LUVerifyDisks that implements the OpVerifyDisks.
      The algorithm is that by determining not-used logical volumes for
      instances that are supposed to be running, we presume from there that
      the DRBD devices are not online and therefore one should
      ‘activate-disks’ for those instances.
      
      Reviewed-by: imsnah
      2c95a8d4
  15. 03 Dec, 2007 1 commit
  16. 27 Nov, 2007 1 commit
  17. 26 Nov, 2007 1 commit
    • Iustin Pop's avatar
      Split the change of peer in secondary replace in two operations · 642445d9
      Iustin Pop authored
      This patch splits the single operation of replace peer into two distinct
      phases, in order to make a single change to the instance configuration:
        - detach from network
        - if at least one drbd device succeeded, make one change to the
          instance, pointing all disks to the new peer
        - attach to the new peer
      
      This should eliminate the case when a failure in the second reattach can
      leave the instance with two secondaries.
      
      Reviewed-by: imsnah
      642445d9
  18. 21 Nov, 2007 1 commit
  19. 16 Nov, 2007 2 commits
  20. 12 Nov, 2007 2 commits
    • Michael Hanselmann's avatar
      Fix functions for /etc/hosts. · 9440aeab
      Michael Hanselmann authored
      - Combine hostname and aliases on one line
      - Fix bug with wrongfully removed newline characters
      - Use wrapper for SetEtcHostsEntry in cmdlib
      
      Reviewed-by: iustin
      9440aeab
    • Iustin Pop's avatar
      Relax replace_disks_all meaning for drbd8 · 7df43a76
      Iustin Pop authored
      In order to make the replace secondary action to be done via the same
      opcode parameters for both remote_raid1 and drbd, we must allow the
      LUReplaceDisks to change replace_disks_all for drbd with non-empty
      remote_node into replace_disks_sec.
      
      This fixes gnt-node evacuate and also allows gnt-instace replace-disks
      to have the same syntax for both remote_raid1 and drbd (when replacing
      the secondary).
      
      Reviewed-by: ultrotter
      7df43a76
  21. 09 Nov, 2007 1 commit
  22. 08 Nov, 2007 1 commit
    • Iustin Pop's avatar
      Changes related to logging · 5bfac263
      Iustin Pop authored
      This patch modifes:
        - mcpu.Processor.LogWarning to have its 'hint' parameter as optional
          and only log it if not None
        - cmdlib._WaitForSync to not log directly to stdout/stderr but via the
          proc.Log(Info|Warning) methods
        - the LU attribute 'processor' is renamed to 'proc' to shorten the
          name
      
      Reviewed-by: imsnah
      5bfac263
  23. 07 Nov, 2007 2 commits
    • Iustin Pop's avatar
      Enhance secondary node replace for drbd8 · 0834c866
      Iustin Pop authored
      This (big) patch does two things:
        - add "local disk status" to the block device checks
          (BlockDevice.GetSyncStatus and the rpc calls that call this
          function, and therefore cmdlib._CheckDiskConsistency)
        - improve the drbd8 secondary replace operation using the above
          functionality
      
      The "local disk status" adds a new variable to the result of
      GetSyncStatus that shows the degradation of the local storage of the
      device. Of course, not all device support this - for now, we only modify
      LogicalVolumes and DRBD8 to return degraded in some cases, other devices
      always return non-degraded. This variable should be a subset of
      is_degraded - whenever this variable is true, the is_degraded should
      also be true.
      
      The drbd8 secondary replace uses this variable as we don't care if the
      primary drbd device is network-degraded, only if it has good local disk
      data (ldisk is False).
      
      The patch also increases the protocol version (due to rpc changes).
      
      Reviewed-by: imsnah
      0834c866
    • Michael Hanselmann's avatar
      Check whether init.d script is executable. · 7dd30006
      Michael Hanselmann authored
      Reviewed-by: schreiberal
      7dd30006
  24. 06 Nov, 2007 1 commit
  25. 05 Nov, 2007 3 commits
    • Iustin Pop's avatar
      Handle missing init script at cluster init · c7b46d59
      Iustin Pop authored
      This patch adds a check in the prereq of LUInitCluster for the existence
      of the init script.  This allows a clean abort instead of a stack dump.
      
      Based on a report by admin@steibei.net
      
      Reviewed-by: ultrotter
      c7b46d59
    • Iustin Pop's avatar
      Miscellaneous style fixes · 65fe4693
      Iustin Pop authored
      This patch fixes some minor pylint warnings (unused variables, wrong
      indentation, etc.) and a real bug in the recovery for drbd8 rename
      procedure.
      
      Reviewed-by: imsnah
      65fe4693
    • Guido Trotter's avatar
      Convert os_get to use OS rather than InvalidOS · dfa96ded
      Guido Trotter authored
      In order to do this for simplicity we leave the OSFromDisk function as-is and
      we convert the eventual exception to an OS object in ganeti-noded. The
      unmangling gets simplified and so does the code for checking whether the OS is
      valid.
      
      Reviewed-By: iustinp
      
      dfa96ded
  26. 04 Nov, 2007 1 commit
    • Guido Trotter's avatar
      Make call_os_get a single node function · 00fe9e38
      Guido Trotter authored
      call_os_get is never called with a real list of nodes, so there's no point in
      it being multi-node. Making it single-node till a usage for multi-node call is
      found.
      
      Reviewed-By: iustinp
      00fe9e38
  27. 03 Nov, 2007 1 commit
    • Iustin Pop's avatar
      Implement tag searching · 73415719
      Iustin Pop authored
      This patch adds a search command for locating tags on all objects of the
      cluster using a regex pattern.
      
      Reviewed-by: aat
      73415719