1. 14 Sep, 2007 1 commit
    • Iustin Pop's avatar
      Change _GetWanted* to return names instead of objects · a7ba5e53
      Iustin Pop authored
      On closer look, all except one of the current users of _GetWantedNodes are
      using only the name of the nodes and throw away the other attributes. It makes
      sense to make this function return only the name list (as in the future this
      might be faster than computing all attributes).
      
      Reviewed-by: imsnah
      a7ba5e53
  2. 13 Sep, 2007 2 commits
    • Iustin Pop's avatar
      Move string formatting out of LUQueryInstances · 8a23d2d3
      Iustin Pop authored
      Currently, LUQueryInstances will provide strings for its results. This makes it
      hard for other consumers than "gnt-instance list" to use the OpQueryInstances
      opcode for whatever they wish to.
      
      The change moves the formatting in five of the six cases where this happens to
      the actual gnt-instance.ListInstances procedure and removes the unconditional
      convert to string in LUQueryInstances.Exec()
      
      Reviewed-by: imsnah
      8a23d2d3
    • Iustin Pop's avatar
      Fix the ssh change which breaks remote ssh commands · 72f0f7fd
      Iustin Pop authored
      Explanation: since we use lists and not a string, every argument we give
      is passed unchanged to the remote shell. So, for example, passing
      '/etc/init.d/ganeti restart' to the remote shell, it will try to run the
      path /etc/init.d/ganeti\ restart. With the s space included. This
      breaks, for example, gnt-node add and gnt-cluster command.
      
      The original problem with the backup routines that led to the "'" change
      is that they use a plain " ".join(list), but we don't need to quote the
      whole ssh remote command for this. We can simply use the existing
      utils.ShellQuoteCmd(list) which does the proper quoting of the ';' or
      '&&' metacharacters.
      
      With this change, both gnt-node add, gnt-cluster command and
      export/import work.
      
      This also improves the error-handling behaviour of one cat command by
      making it conditional on the preceding mkdir.
      
      Reviewed-by: ultrotter
      72f0f7fd
  3. 12 Sep, 2007 3 commits
  4. 11 Sep, 2007 2 commits
  5. 07 Sep, 2007 1 commit
    • Guido Trotter's avatar
      Make import/export use the auxiliary ssh library to build the remote commands. · 00003458
      Guido Trotter authored
      This avoids forgetting some parameters, as it's happening right now 
      (the correct known host file is not being passed)
      
      In order to do so we split SSHCall into an auxiliary BuildSSHCmd which builds
      the command but doesn't actually call it, and SSHCall itself which runs RunCmd
      on top of BuildSSHCmd's result. BuildSSHCmd is then explicitely called by 
      import/export who has to build a more complex command to be run later.
      00003458
  6. 05 Sep, 2007 1 commit
  7. 04 Sep, 2007 1 commit
  8. 03 Sep, 2007 2 commits
    • Michael Hanselmann's avatar
      - Generic automake cleanup · 7c18ef8e
      Michael Hanselmann authored
      - Bump version number to 1.2b2
      - Add version.py file generated from version.py.in by autoconf
      
      Reviewed-by: schreiberal
      7c18ef8e
    • Iustin Pop's avatar
      Switch utils.RunCmd from popen2 to subprocess · 113b55aa
      Iustin Pop authored
      This changes the implementation of RunCmd from using the popen2 module
      to using the (new in 2.4) subprocess module.
      
      This is helpful because the subprocess module has more advanced features
      than popen2, the most important ones being the ability to run code in the
      child process before the exec and ability to launch with modified
      environment.
      
      Reviewed-by: imsnah
      113b55aa
  9. 30 Aug, 2007 5 commits
  10. 28 Aug, 2007 2 commits
  11. 24 Aug, 2007 1 commit
    • Iustin Pop's avatar
      Rework ssh known-hosts handling. · 82122173
      Iustin Pop authored
      This changes:
        - cluster setup, we no longer edit /etc/ssh/ssh_known_hosts but our
          own file
        - node add, we no longer remove root's known_hosts (twice)
        - gnt-instance console, both the LU and the script: since now the ssh
          setup is not standard, we need to build the ssh cmdline in the LU
          (instead of manually building it in the script) with the correct
          parameters and use the command line as returned in the script
        - ssh.py, many changes, split options in module-level constants so
          that building the command line in different places is easier/more
          logical
        - backend.py, we no longer remove root's known_hosts in Add node, and
          we allow our own known_hosts file to be uploaded
      
      Reviewed-by: imsnah
      82122173
  12. 23 Aug, 2007 1 commit
    • Iustin Pop's avatar
      Improve LURunClusterCommand · 02715459
      Iustin Pop authored
      This function used a hand-coded ssh call to remote nodes. Fix it to use the
      ssh.SSHCall function, and in the process drop the command field from the
      results, as it's too verbose and we can use (in gnt-cluster) what we passed in.
      
      Reviewed-by: schreiberal
      02715459
  13. 22 Aug, 2007 1 commit
  14. 21 Aug, 2007 1 commit
  15. 20 Aug, 2007 3 commits
  16. 17 Aug, 2007 1 commit
    • Iustin Pop's avatar
      Change cli.OutputTable to cli.GenerateTable · 16be8703
      Iustin Pop authored
      Since the table generation might be useful elsewhere, let's change it to
      return the data instead of directly printing it.
      
      Its callers have also been updated.
      
      Reviewed-by: imsnah
      16be8703
  17. 16 Aug, 2007 1 commit
    • Iustin Pop's avatar
      Some small fixes. · 8925faaa
      Iustin Pop authored
      It fixes the main Makefile.am to create $localstatedir/{lib,log}/ganeti.
      It fixes the testing Makefile.am after the rename fake_config.py ->
      mocks.py.  It strips the output of "ip link show" to have a nicer output
      if the master netdev does not exist.
      8925faaa
  18. 14 Aug, 2007 1 commit
    • Iustin Pop's avatar
      Style changes for pep-8 and python-3000 compliance. · 3ecf6786
      Iustin Pop authored
      This changes the raising of exceptions from:
        raise Exception, value
      to
        raise Exception(value)
      
      as the first form will be removed in python-3000 and the second form is
      preferred now.
      
      The changes also involve a few cases of changing from raising standard
      exceptions and use our own ones.
      
      The new version also fixes many pylint-generated warnings, especially in
      ganeti-noded where I changed many methods to @staticmethod.
      
      There is no functionality changed (barring any bugs).
      3ecf6786
  19. 08 Aug, 2007 1 commit
  20. 06 Aug, 2007 1 commit
  21. 03 Aug, 2007 6 commits
  22. 02 Aug, 2007 2 commits