1. 07 Mar, 2012 1 commit
  2. 29 Feb, 2012 1 commit
  3. 13 Jan, 2012 5 commits
  4. 08 Dec, 2011 1 commit
    • Iustin Pop's avatar
      Cleanup hlint errors · 3603605a
      Iustin Pop authored
      
      
      First, we update the recommended hlint version to what I used to get a
      clean output (1.8.15). Most of the changes are:
      
      - remove unneeded parentheses
      - some simplifications (intercalate " " → unwords, maybe … id →
        fromMaybe, etc.)
      - removal of some duplicate code (in previous patches)
      
      There are still some warnings which I didn't clean out but plain
      ignored:
      
      - 'Eta reduce' in some specific files, because the type inference
        specialises the function on the first call, and annotating the type
        properly would be too verbose
      - use of 'first', 'comparing', and 'on', since these don't seem to be
        widely or consistently used (outside ganeti/htools, I mean)
      - use of Control.Exception.catch, as we only care about I/O errors; at
        one point yes, we will need to transition to this new API
      - 'Reduce duplication', since hlint warns even for 3 duplicate lines,
        and abstracting that away seems overkill to me
      
      After this patch, make hlint is clean and doesn't exit with an error
      anymore; we could enable it automatically on 'make lint' if hlint is
      detected (future patch).
      
      Note that we explicitly skip the THH.hs file from checking because it
      seems that hlint doesn't parse correctly for now the splice notation.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAgata Murawska <agatamurawska@google.com>
      3603605a
  5. 17 Nov, 2011 1 commit
  6. 16 Nov, 2011 3 commits
  7. 12 Oct, 2011 1 commit
  8. 08 Aug, 2011 1 commit
    • Iustin Pop's avatar
      Revert deprecation of evacuate mode in hail · 88df1fa9
      Iustin Pop authored
      As discussed offline, the new node-change mode could be used for
      evacuation, but it's not directly useful as it returns a list of
      opcodes; therefore, we need to partially revert commits fbe5fcf6 and
      5b53ca79
      
       that removed it (and multi-evacuate, which remains removed).
      
      The new version of relocate is actually just a wrapper over the
      tryNodeEvac (which does the node evacuate); we run that and then we do
      some extra checks that the nodes we got from that function are
      consistent with the instance's new state.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      88df1fa9
  9. 21 Jul, 2011 1 commit
  10. 20 Jul, 2011 1 commit
    • Guido Trotter's avatar
      Do proper name lookup for the -O option · 4938fa30
      Guido Trotter authored
      
      
      hspace and hbal treat -O differently, and use aliases for short names
      (although hbal succeeds in that, and hspace doesn't). Uniform this with
      a name lookup, using the same functions we used for instance
      selection/exclusion.
      
      Some of the code is by the way a bit repetitive, and could probably be
      merged in a single function. That needs to be a monadic one, though, so
      I promise to do it as soon as I realize how to write them! ;)
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      4938fa30
  11. 19 Jul, 2011 1 commit
  12. 15 Jul, 2011 1 commit
  13. 13 Jul, 2011 4 commits
  14. 17 Jun, 2011 3 commits
  15. 01 Jun, 2011 1 commit
  16. 23 Mar, 2011 1 commit