1. 13 Jul, 2012 1 commit
  2. 11 Jul, 2012 1 commit
  3. 07 Jul, 2012 1 commit
  4. 05 Jul, 2012 2 commits
  5. 27 Jun, 2012 4 commits
  6. 20 Jun, 2012 1 commit
    • Iustin Pop's avatar
      Fix bug in instance net changes · 80b898f9
      Iustin Pop authored
      
      
      _PrepareNicModification returns the invalid type, which triggers an
      assert resulting in a mysterious error:
      
      Failure: command execution error:
      
      Without any explanation. We fix this by removing the return value from
      _PrepareNicModification, and instead returning the expected type
      (since it differs per create/modification) from the (existing)
      wrappers for this function. We don't need to return actual changes
      from this function as _ApplyNicMods is the function that
      computes/returns the formatted changes.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Signed-off-by: default avatarRené Nussbaumer <rn@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      80b898f9
  7. 15 Jun, 2012 1 commit
  8. 14 Jun, 2012 1 commit
  9. 08 Jun, 2012 1 commit
  10. 01 Jun, 2012 1 commit
    • Iustin Pop's avatar
      Fix a type issue and bad logic in cluster verification · e375fb61
      Iustin Pop authored
      Commit 2e04d454
      
       introduced the new offline state for the instance
      state, but being a big monolithic patch it sneaked in something that
      doesn't make sense.
      
      The checks for extra instances (either wrongly up or just unknown) are
      done purely on a name-basis, not on objects, so the types there are
      wrong. Furthermore, they have no relation to the admin state of the
      instance, so we just drop the entire if block. We keep the increment
      of the offline instance count, but move it to a different loop over
      instances.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      e375fb61
  11. 22 May, 2012 2 commits
  12. 15 May, 2012 3 commits
  13. 14 May, 2012 3 commits
  14. 11 May, 2012 2 commits
  15. 10 May, 2012 8 commits
  16. 26 Apr, 2012 1 commit
  17. 20 Apr, 2012 2 commits
  18. 19 Apr, 2012 1 commit
  19. 16 Apr, 2012 1 commit
  20. 11 Apr, 2012 3 commits
    • Iustin Pop's avatar
      Fix extra whitespace · 612f7fd4
      Iustin Pop authored
      
      
      Sorry, didn't catch this before…
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      (cherry picked from commit 54b010ca
      
      )
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      612f7fd4
    • Dimitris Aragiorgis's avatar
      Further fixes concerning drbd port release · 42f25b0b
      Dimitris Aragiorgis authored
      Commit 3b3b1bca does not entirely fix the bug introduced in commit
      f396ad8c
      
      . It fixes consistency of config data in permanent storage, but
      does not ensure consistency in data held in runtime memory of masterd.
      
      The bug of duplicate ports is still triggered when LUInstanceRemove()
      invokes _RemoveDisks() and this returns False (in case
      call_blockdev_remove RPC fails). The drbd ports get returned in the
      pool, but execution is aborted and RemoveInstance() is never invoked.
      
      Due to the fact that port handling is not done with
      TemporaryReservationManager, ensure that ports are released, only if
      disk related config data is deleted.
      
      In _RemoveDisks() release ports only if all RPCs succeed.
      
      Extend _RemoveDisks() to include ignore_failures argument passed by
      _RemoveInstance() to handle the ports appropriately.
      Signed-off-by: default avatarDimitris Aragiorgis <dimara@grnet.gr>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      42f25b0b
    • Dimitris Aragiorgis's avatar
      Fix a bug concerning TCP port release · 2522b7c4
      Dimitris Aragiorgis authored
      Commit f396ad8c
      
       returns the TCP port used by DRBD disk back to the
      TCP/UDP port pool using AddTcpUdpPort().
      
      However, AddTcpUdpPort() writes the config on every invocation,
      using _WriteConfig(). This causes two problems:
      
       * it causes critical errors logged by VerifyConfig(), after the DRBD
         disk removal, and until the actual instance removal.
       * if the code following AddTcpUdpPort() fails, the port is already
         returned back the pool, which causes the port to have duplicates
         (inconsistent config).
      
      AddTcpUdpPort() is invoked in three cases:
      
       * during InstanceRemove() through _RemoveDisks().
       * during InstanceSetParams() in case of disk removal.
       * during InstanceSetParams() through _ConvertDrbdToPlain().
      
      This commit fixes the problem by removing the _WriteConfig() call from
      AddTcpUdpPort(), delegate it to Update() via the
      TemporaryReservationManager and ensure AddTcpUdpPort() precedes
      Update().
      Signed-off-by: default avatarDimitris Aragiorgis <dimara@grnet.gr>
      [iustin@google.com: small comments adjustements]
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      (cherry picked from commit 3b3b1bca)
      2522b7c4