1. 23 May, 2014 1 commit
    • Dimitris Aragiorgis's avatar
      Fix QueryNetworks wrt instances · 96092119
      Dimitris Aragiorgis authored
      
      
      QueryNetworks tries to find which instances are connected to which
      networks. The query mechanism in Haskell was written back when NICs
      referred to a network via its name and not its UUID. Fix luxi to
      comply with the current implementation (network slot of NIC object
      is a UUID).
      
      Fix old style query mechanism to return a list of names instead of
      UUIDs for the instances that are connected to a network.
      Signed-off-by: default avatarDimitris Aragiorgis <dimara@grnet.gr>
      Reviewed-by: default avatarHelga Velroyen <helgav@google.com>
      96092119
  2. 10 Jul, 2013 1 commit
  3. 04 Jul, 2013 1 commit
  4. 28 May, 2013 1 commit
  5. 23 May, 2013 1 commit
  6. 15 May, 2013 4 commits
  7. 30 Apr, 2013 1 commit
    • Iustin Pop's avatar
      Fix bug in group queries related to node/instance fields · c42fbe28
      Iustin Pop authored
      
      
      Since we use the primitive string type for group UUIDs, the group
      fields have a bug where we pass the group name as filter for node
      tests, whereas the nodes themselves use the group UUID. This results
      in zero node count, empty node list, and no instances being reported
      as assigned to groups.
      
      The patch fixes this and adds a test for the node count. It does some
      test generation improvement, and also cleans up whitespace issues in
      Test/G/Q/Query.hs (the functions case_queryNode_allfields,
      prop_queryGroup_noUnknown and case_queryGroup_allfields are unchanged
      but simply have indentation fixed).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      
      Cherry-pick of e7124835
      
      , fixes issue 436
      Signed-off-by: default avatarKlaus Aehlig <aehlig@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      
      Conflicts:
      	test/hs/Test/Ganeti/Objects.hs
      	test/hs/Test/Ganeti/Query/Query.hs
      c42fbe28
  8. 24 Apr, 2013 1 commit
  9. 17 Apr, 2013 1 commit
  10. 27 Mar, 2013 1 commit
  11. 12 Mar, 2013 2 commits
  12. 04 Mar, 2013 1 commit
    • Iustin Pop's avatar
      Fix bug in group queries related to node/instance fields · e7124835
      Iustin Pop authored
      
      
      Since we use the primitive string type for group UUIDs, the group
      fields have a bug where we pass the group name as filter for node
      tests, whereas the nodes themselves use the group UUID. This results
      in zero node count, empty node list, and no instances being reported
      as assigned to groups.
      
      The patch fixes this and adds a test for the node count. It does some
      test generation improvement, and also cleans up whitespace issues in
      Test/G/Q/Query.hs (the functions case_queryNode_allfields,
      prop_queryGroup_noUnknown and case_queryGroup_allfields are unchanged
      but simply have indentation fixed).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      e7124835
  13. 18 Feb, 2013 1 commit
  14. 11 Feb, 2013 1 commit
  15. 07 Feb, 2013 1 commit
  16. 24 Jan, 2013 1 commit
  17. 15 Jan, 2013 1 commit
  18. 27 Dec, 2012 1 commit
    • Iustin Pop's avatar
      Move htest/ files under the test/ tree · 83846468
      Iustin Pop authored
      htest/data becomes test/data/htools (basically reverting commit
      8feabc89
      
      ), and htest/* becomes test/hs/*.
      
      Most changes beside the rename are trivial s/…/…, with the exception
      of autotools/run-in-tempdir, which needed some more changes now that
      test/ is not just Python files:
      
      - test/py is still being copied
      - test/hs moves from individual symlinks to entire dir symlink
      - test/data is symlinked in its entirety
      
      Checked with make distcheck, pep8 and pylint, so at least VPATH builds
      are OK.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      83846468
  19. 20 Dec, 2012 1 commit
  20. 19 Dec, 2012 3 commits
  21. 18 Dec, 2012 1 commit
  22. 11 Dec, 2012 1 commit
  23. 07 Dec, 2012 1 commit
  24. 06 Dec, 2012 1 commit
  25. 04 Dec, 2012 1 commit
  26. 30 Nov, 2012 3 commits
  27. 21 Nov, 2012 2 commits
    • Iustin Pop's avatar
      Move the 'Hypervisor' type from Objects to Types · 22381768
      Iustin Pop authored
      
      
      This is a very basic type and 'Objects' is a heavy-weight module. By
      moving it to 'types' we simplify (in the future) the import chains.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAdeodato Simo <dato@google.com>
      22381768
    • Iustin Pop's avatar
      Generalise the JSON "Container" type · edc1acde
      Iustin Pop authored
      
      
      Currently, we have some types that we kept as dictionaries in the
      objects representation (due to inconsistent behaviour, or other
      technical reasons). This should be improved in the future, but in the
      meantime we can improve the Container type by allowing its keys to be
      non-strings; this is needed, for example, for better safe in
      DiskParams type, where we don't want arbitrary strings as keys, but
      only the actually defined types.
      
      To implement this change, we generalise the type (Container →
      GenericContainer), and in the process we introduce a type class for
      "things that can be represented as strings". This is very similar to a
      combination of Read and Show, but with custom string
      representation. The new type class is needed because in JSON
      representation, object keys must be strings, so we need to be able to
      serialised/deserialise the generic keys to/from plain strings.
      
      We also add the instance for DiskTemplate at the same time.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAdeodato Simo <dato@google.com>
      edc1acde
  28. 20 Nov, 2012 1 commit
    • Iustin Pop's avatar
      Create a new Ganeti/Types.hs module · 5e9deac0
      Iustin Pop authored
      There are already three cases where we copied type definitions between
      the htools-specific types into the main ganeti code. Let's stop doing
      this 
      
       and create a common types module that holds these.
      
      Note that there already exists BasicTypes.hs, but that refers to very
      low-level types, and can't use TH derivation itself.
      
      A side effect of this unification is that there is a small conflict
      between AdminStatus/AdminOffline and InstanceStatus/AdminOffline. As
      such, I renamed AdminOffline and AdminDown to StatusOffline/StatusDown
      in the InstanceStatus type.
      
      The patch also moves the tests related to these types to a new test
      module.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAdeodato Simo <dato@google.com>
      5e9deac0
  29. 22 Oct, 2012 1 commit
  30. 07 Sep, 2012 2 commits