1. 16 Nov, 2012 1 commit
  2. 15 Nov, 2012 2 commits
  3. 13 Nov, 2012 4 commits
    • Michael Hanselmann's avatar
      Add new test for RAPI · 105f0d47
      Michael Hanselmann authored
      
      
      Unlike existing tests, this actually tests RAPI at the interface with
      the HTTP server. This way authentification can also be tested. A test
      for “/2/query/…” is included as it's a bit special.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarBernardo Dal Seno <bdalseno@google.com>
      105f0d47
    • Iustin Pop's avatar
      Automatically enable version-dependent GHC flags · 39f0eea5
      Iustin Pop authored
      
      
      Some GHC flags are very useful, but only appear in more recent GHC
      versions. To support the use of such flags while still supporting
      older compilers, let's add conditional checks and enabling based on
      the results.
      
      Currently only `-fwarn-incomplete-uni-patterns` is enabled, which
      detects refutable patterns in lambda expressions and pattern bindings
      (e.g. "let (Just x) = y"); such constructs are bad as they can lead to
      runtime exceptions.
      
      Additionally, fix an existing such bad construct in a test case; we
      workaround it by using error, since that should never fail.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      39f0eea5
    • Michele Tartara's avatar
      Added attoparsec unit test for Unicode parsing · 43b3b5c1
      Michele Tartara authored
      
      
      Attoparsec is known to have had issues with parsing non-ASCII strings.
      This test makes sure that parsing of Unicode characters works fine.
      Signed-off-by: default avatarMichele Tartara <mtartara@google.com>
      [iustin: small doc string fixes]
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      43b3b5c1
    • Iustin Pop's avatar
      Improve make regen-vcs-version · 6376dcc0
      Iustin Pop authored
      
      
      "make regen-vcs-version" is run at every ./devel/upload time, in order
      to have reasonably up-to-date information in the uploaded
      scripts/binaries. However, this means it currently triggers
      recompilation of (at least) Ganeti/Version.hs, and sometimes more than
      that.
      
      Since we only care about the contents of the file and not the
      timestamp, let's change the make rule so that it only updates the file
      if there are actually changes in the content, as checked by
      "cmp". This results in a much faster ./devel/upload, especially for
      small changes in the (non-Haskell) code, or when the code has already
      been compiled.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      6376dcc0
  4. 08 Nov, 2012 1 commit
  5. 07 Nov, 2012 1 commit
    • Iustin Pop's avatar
      Switch devel/upload to a static file · f9435bdc
      Iustin Pop authored
      
      
      We had twice in the past days questions about devel/upload being
      "broken", since bash re-reads shell scripts during their run and this
      file can get regenerated due to Makefile changes.
      
      Since we only need this to be dynamically built for 3 variables, let's
      make the file static and read those three variables when it is run,
      instead of when it is built, which allows us to re-read the "latest
      version" of these vars as well.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      f9435bdc
  6. 06 Nov, 2012 1 commit
  7. 26 Oct, 2012 3 commits
  8. 25 Oct, 2012 3 commits
  9. 24 Oct, 2012 2 commits
  10. 23 Oct, 2012 1 commit
  11. 22 Oct, 2012 2 commits
  12. 18 Oct, 2012 1 commit
  13. 17 Oct, 2012 2 commits
  14. 16 Oct, 2012 5 commits
  15. 12 Oct, 2012 3 commits
  16. 11 Oct, 2012 1 commit
  17. 10 Oct, 2012 2 commits
  18. 08 Oct, 2012 5 commits
    • Iustin Pop's avatar
      Merge ganeti-master-cleaner back into ganeti-cleaner · 46118ed2
      Iustin Pop authored
      As I wrote during/after the review on commit 2958c56e
      
      , “ganeti-cleaner:
      Separate queue cleaning code”, while I appreciated the permission
      separation, I didn't like too much the file-based approach:
      
      - it is a very simple script, and lots of the code is duplicated
        between the two; I wouldn't like to see "ganeti-vmcapable-cleaner",
        "ganeti-master-candidate-cleaner", etc. in the future
      - ganeti-master-cleaner "pollutes" the namespace, creating
        tab-completion conflicts with ganeti-masterd
      
      This patch simply merges the master-cleaner back into cleaner, while
      keeping the separate user permissions scheme, separate log files, etc.
      
      Additionally, it fixes two bugs in the unit-test (not run with set -u
      and wrong path in the master-cleaner log files test; yay for even
      worse safety than Python?).
      
      And finally, since we have now support for --help-completion, it adds
      bash completion support for this script :) (needs to be applied on top
      of my argument support patch series).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      46118ed2
    • Iustin Pop's avatar
      Enable bash completion for Haskell daemons too · f8d01158
      Iustin Pop authored
      
      
      This requires a few tiny changes to build-bash-completion and to
      Makefile rules, but is straightforward.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      f8d01158
    • Iustin Pop's avatar
      A few cleanups in Makefile.am · dad26941
      Iustin Pop authored
      
      
      A lot of the lists in Makefile.am were not sorted properly (or at
      all); let's sort them for more sanity.
      
      Additionally, check-local used to spew this big shell block, even
      though it does emit nice messages when failing, so we don't need to
      show the code; let's silence it (@).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      dad26941
    • Iustin Pop's avatar
      Fixup TAGS generation with newer GHC · 6b84f036
      Iustin Pop authored
      
      
      Newer GHC refuses to allow "-O" with interactive mode, so let's filter
      that out. Furthermore, sometimes you don't have a clean tree exactly
      when you need to look up something/update the tags, so let's filter
      out the "-Werror" too.
      
      And finally, we need to pass the actual exact flags (including
      nocurl, parallel, etc.) that we use for building, so let's add those
      too.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      6b84f036
    • Iustin Pop's avatar
      Rename Ganeti/HTools/Utils.hs to Ganeti/Utils.hs · 26d62e4c
      Iustin Pop authored
      
      
      This is, I believe, the last non-htools specific file that still lived
      in the htools directory; it's already widely used in non-htools code,
      so let's move it before we add more functionality to this module.
      
      All changes are related to the name change, imports fixup, etc.; there
      are no other changes in this patch.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      26d62e4c