1. 29 Jun, 2012 1 commit
  2. 28 Jun, 2012 1 commit
  3. 25 Jun, 2012 1 commit
  4. 11 Jun, 2012 2 commits
    • Iustin Pop's avatar
      Fix make -n use · 316dc1ff
      Iustin Pop authored
      Due to the way $(MAKE) behaves (it forces execution of the commands
      that contain it), use of $(MAKE) in a command line together with
      side-effects commands will break stuff. It's better to keep it either
      on a separate line, or if not possible, move said commands to a
      separate make target.
      
      After this patch, make -n distcheck, make -n regen-vcs-version and
      possibly other commands now work correctly.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      316dc1ff
    • Iustin Pop's avatar
      Enable hlint in lint and reorganise this target · 6e4c8f68
      Iustin Pop authored
      Currently, the lint target does a sequential: pep8, pylint, pylint on
      the QA sources. hlint is run only when explicitly requested.
      
      This patch reorganises the lint target by:
      
      - splitting the current lint target into separate pylint (slow),
        pylint-qa (fast), pep8 (fast) targets
      - making lint itself depend on the above plus hlint
      - both pep8 and hlint are optional, based on whether the said binaries
        were detected at configure time
      
      make -j is slightly faster after this patch (1m18s → 1m7s).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      6e4c8f68
  5. 08 Jun, 2012 1 commit
  6. 06 Jun, 2012 1 commit
    • Iustin Pop's avatar
      Fix parallel build failures · a13d6911
      Iustin Pop authored
      This is the 2.5 version of the "fix build failures":
      
      - man/%.gen could be left over even in case of failure, due to
        automake bug
      - make man/%.gen runs RUN_IN_TEMPDIR, so let's depend on it, since
        that target has the proper dependencies (create needed dirs)
      - man/%.gen depends on a number of built sources, but the dependency
        was not declared
      
      Furthermore, wraps a long comment.
      
      Tested with -j4/-j16, after `make maintainer-clean'.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      a13d6911
  7. 31 May, 2012 1 commit
  8. 22 May, 2012 1 commit
  9. 11 May, 2012 2 commits
  10. 08 May, 2012 1 commit
  11. 04 May, 2012 1 commit
  12. 26 Apr, 2012 1 commit
  13. 30 Mar, 2012 1 commit
  14. 27 Mar, 2012 1 commit
  15. 26 Mar, 2012 3 commits
  16. 23 Mar, 2012 1 commit
    • Iustin Pop's avatar
      Enable selection between Python and Haskell confd · 73b0fa69
      Iustin Pop authored
      This patch changes configure.ac Makefile.am so that the user can pass:
      
      - --disable-confd (or --enable-confd=no) to disable it completely
      - --enable-confd=yes or --enable-confd=python to select the
        traditional implementation (this is the default setting)
      - --enable-confd=haskell to select hconfd
      
      The only "not nice" thing is that I've chosen to keep the
      hconfd.hs/hconfd name, and we rename it after install via an
      install-exec-hook. The other choice is possible too (to rename the
      source file/binary).
      
      One additional note is that if we select haskell, the _rule_ for
      creating daemons/ganeti-confd dissapears; whereas if we select python,
      the rule for htools/hconfd still exists (one can build it explicitly),
      it just is not installed. This is due to the different way in which
      the rules are declared.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      73b0fa69
  17. 22 Mar, 2012 2 commits
    • Iustin Pop's avatar
      Fix out-of-tree builds · 3e5012c6
      Iustin Pop authored
      The new shell tests do not succeed out-of-tree, due to static paths
      and other issues. This trivial patch fixes these issue, make distcheck
      now passes.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      3e5012c6
    • Iustin Pop's avatar
      Convert manual shell tests to shelltestrunner · 53d4cdf1
      Iustin Pop authored
      This is more of a RFC… Basically most of the shell-based tests are
      converted from exec+grep to shelltestrunner.
      
      Things are not all fine and nice though:
      
      - we have dependencies between tests, as some generate some data files
        needed later; this is not nice, and we depend on serial execution in
        testrunner
      - we can still fail with no so nice messages in the offline-test
        script (when we generate most of the data)
      
      But overall, I think the tests are much nicer to
      define/read/debug:
      
      - each test is standalone, with the only dependency being an optional
        input data file; this is much better than a single monolithic shell
        script
      - in case of failures, the failure is clearly shown by shell test,
        both for exit code and stdout/stderr
      - shelltest can run in --debug mode, where the exact details are shown
        much better than the alternative of "set -x" for the shell script
      
      Comments welcome!
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      53d4cdf1
  18. 21 Mar, 2012 2 commits
  19. 20 Mar, 2012 1 commit
  20. 19 Mar, 2012 2 commits
  21. 15 Mar, 2012 3 commits
  22. 14 Mar, 2012 1 commit
  23. 13 Mar, 2012 9 commits