1. 20 Oct, 2009 1 commit
  2. 13 Oct, 2009 1 commit
  3. 12 Oct, 2009 1 commit
  4. 09 Oct, 2009 2 commits
  5. 05 Oct, 2009 3 commits
  6. 02 Oct, 2009 4 commits
  7. 01 Oct, 2009 1 commit
  8. 25 Sep, 2009 1 commit
    • Iustin Pop's avatar
      Fix the confusing ssh/hostname message in node add · 31821208
      Iustin Pop authored
      Before, it used to say:
        ssh/hostname verification failed node1.example.com -> hostname mismatch, got
      Now it says for wrong hostnames (maybe too verbose):
        ssh/hostname verification failed (checking from node1.example.com): hostname
        mismatch, expected node2.example.com but got node3
      And for non-FQDN hostnames:
        ssh/hostname verification failed (checking from node1.example.com): hostname
        not FQDN: expected node2.example.com but got node2
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
  9. 24 Sep, 2009 3 commits
  10. 21 Sep, 2009 2 commits
  11. 17 Sep, 2009 3 commits
    • Michael Hanselmann's avatar
    • Iustin Pop's avatar
      Add an error-simulation mode to cluster verify · a0c9776a
      Iustin Pop authored
      One of the issues we have in ganeti is that it's very hard to test the
      error-handling paths; QA and burnin only test the OK code-path, since
      it's hard to simulate errors.
      LUVerifyCluster is special amongst the LUs in the fact that a) it has a
      lot of error paths and b) the error paths only log the error, they don't
      do any rollback or other similar actions. Thus, it's enough for this LU
      to separate the testing of the error condition from the logging of the
      error condition.
      This patch does this by replacing code blocks of the form:
        if x:
        [if x:
      After this change, it's simple enough to turn on logging of all errors
      by adding a special case inside log_error_if such that if the incoming
      opcode has a special ‘debug_simulate_errors’ attribute and it's true, it
      will log unconditionally the error.
      Surprisingly this also turns into an absolute code reduction, since some
      of the if blocks were simplified. The only downside to this patch is
      that the various _VerifyX() functions are now stateful (modifying an
      attribute on the LU instance) instead of returning a boolean result.
      Last note: yes, this discovered some error cases in the logging.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
    • Iustin Pop's avatar
      Introduce parseable error codes in LUVerifyCluster · 7c874ee1
      Iustin Pop authored
      Currently the output of cluster verify can be parsed for 'ERROR'
      messages, but that is the only indication we get (error or no error). In
      order to allow monitoring tools to separate different error conditions,
      this patch introduces a new output format (“gnt-cluster verify
      --error-codes”) that changes the output from human-friendly to
      machine-friendly. In this mode, an error line changes from:
        ERROR: node node1: drbd minor 1 of instance inst1.is not active
        ERROR:ENODEDRBD:node:node1:drbd minor 1 of instance inst1 is not active
      i.e. the error message is a ‘:’-separated field, with ERROR in the first
      place, the error code in the second, the object type (cluster, node,
      instance) in the third, the name of the object (for nodes/instances) in
      the fourth, and then the text message.
      The patch also removes some of the verbosity of the operation
      (“Verifying instance X”, “Verifying node X”) since on big clusters these
      informational messages can quickly fill up an entire screen. The
      original behaviour can be restored via the ‘--verbose’ option.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
  12. 16 Sep, 2009 1 commit
  13. 14 Sep, 2009 2 commits
  14. 11 Sep, 2009 2 commits
  15. 08 Sep, 2009 1 commit
  16. 03 Sep, 2009 1 commit
  17. 31 Aug, 2009 1 commit
  18. 26 Aug, 2009 2 commits
  19. 25 Aug, 2009 4 commits
  20. 24 Aug, 2009 4 commits