1. 24 Sep, 2009 3 commits
  2. 22 Sep, 2009 1 commit
  3. 17 Sep, 2009 1 commit
  4. 03 Sep, 2009 1 commit
  5. 17 Aug, 2009 1 commit
  6. 11 Aug, 2009 1 commit
  7. 10 Aug, 2009 1 commit
  8. 05 Aug, 2009 2 commits
  9. 16 Jul, 2009 2 commits
    • Guido Trotter's avatar
      Add a few more checks to verify config · 9a5fba23
      Guido Trotter authored
      
      
      - Check that the enabled hypervisors list is valid
      - Check that the master node is a valid node
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      9a5fba23
    • Guido Trotter's avatar
      Get rid of the default_hypervisor slot · 066f465d
      Guido Trotter authored
      
      
      Currently we have both a default_hypervisor and an enabled_hypervisors
      list. The former is only settable at cluster init time, while the latter
      can be changed with cluster modify.
      
      This becomes cumbersome in a few ways: at cluster init time for example
      if we pass in a list of enabled hypervisors which doesn't include the
      "default" xen-pvm one, we're also forced to pass a default hypervisor,
      or an error will be reported. It is also currently possible to disable
      the default hypervisor in cluster-modify (with unknown results).
      
      In order to avoid this we get rid of this field altogether, and define
      the "first" enabled hypervisor as the default one. This allows ease of
      changing which one is the default, and at the same time maintains
      coherency.
      
      At configuration upgrade we make sure that the old default is first in
      the list, so that 2.0 cluster defaults are preserved.
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      066f465d
  10. 14 Jul, 2009 1 commit
  11. 07 Jul, 2009 2 commits
  12. 30 Jun, 2009 1 commit
  13. 15 Jun, 2009 2 commits
  14. 10 Jun, 2009 1 commit
  15. 28 May, 2009 1 commit
  16. 06 Apr, 2009 1 commit
    • Iustin Pop's avatar
      Add a new ssconf file with the cluster tags · 5d60b3bd
      Iustin Pop authored
      Since the cluster tags are/should be more-or-less static, add them as an
      ssconf key, so that querying them is possible without creating a
      job/requiring the masterd to be running.
      
      Reviewed-by: imsnah
      5d60b3bd
  17. 27 Feb, 2009 1 commit
    • Iustin Pop's avatar
      Fix some epydoc style issues · 5fcc718f
      Iustin Pop authored
      99% of the epydoc return tags are "@return:", but each of the modified files
      had one "@returns:" line. We fix this for consistency.
      
      Reviewed-by: imsnah
      5fcc718f
  18. 12 Feb, 2009 4 commits
    • Guido Trotter's avatar
      ConfigWriter.AddInstance check instance mac · e4640214
      Guido Trotter authored
      There is a race condition in CreateInstance, since the mac address is
      generated early and only added to the config (and thus really assured to
      be unique) only at this point. Since it's possible that another instance
      gets the same mac address in the meantime with this check we'll make the
      instance creation fail before modifying the config data and thus having
      a wrong in-memory config (which is bad!!).
      
      Note that the same race condition exists, for example, in
      SetInstanceParams, and should be fully addressed by a way to revert
      config changes if writing them fails!
      
      Reviewed-by: iustin
      e4640214
    • Iustin Pop's avatar
      Do not check 'None' disk IDs for duplicates · 25ae22e4
      Iustin Pop authored
      In case of 'None' logical or physical IDs, we don't need to check them
      for duplicates. This case can happen for DRBD devices in case of newly
      added disks, for example.
      
      Reviewed-by: imsnah
      25ae22e4
    • Iustin Pop's avatar
      Prevent race condition on MAC addresses · e7d81ba0
      Iustin Pop authored
      This patch adds a temporary set for MACs that have been requested but
      are not yet in the configuration (as part of an instance NIC). The MACs
      of an instance are automatically removed from this set when the instance
      is updated (or first added to the config).
      
      Reviewed-by: ultrotter
      e7d81ba0
    • Iustin Pop's avatar
      ConfigWriter: add checks for duplicate disk IDs · 4b98ac29
      Iustin Pop authored
      This patch adds a safety check for duplicate disk logical/physical IDs,
      in order to prevent possible software bugs.
      
      Reviewed-by: imsnah
      4b98ac29
  19. 10 Feb, 2009 1 commit
    • Iustin Pop's avatar
      ConfigWriter: handle the drained node flag · 5bf07049
      Iustin Pop authored
      This patch changes the master candidate pool computations in
      ConfigWriter to properly handle drained nodes. They are now excluded
      from counting towards the reachable number of candidates.
      
      The patch also adds verification of consistency for the node status.
      
      Reviewed-by: imsnah
      5bf07049
  20. 04 Feb, 2009 1 commit
    • Iustin Pop's avatar
      ssconf: add some more keys and some fixes · 81a49123
      Iustin Pop authored
      This patch adds the online node list and instance list to the ssconf
      keys. In order to do distribute correctly the instance list, we need to
      update the cluster serial number on instance additions and removals.
      
      The patch also changes the permissions on the ssconf files to be 0444:
        - no write for root, in order to signal that these file should not be
          modified
        - read for everyone since the files don't contain sensitive data
          anymore (and permissions can be controlled via the parent directory
          if needed)
      
      The patch also fixes a small typo on gnt-cluster.
      
      Reviewed-by: ultrotter
      81a49123
  21. 27 Jan, 2009 1 commit
    • Iustin Pop's avatar
      Implement disk verify checks in config verify · 332d0e37
      Iustin Pop authored
      This patch adds a simple check that the 'mode' attribute of top-level disks is
      correct. It does not recurse over children.
      
      The framework could be extended with other checks in the future.
      
      Reviewed-by: imsnah
      332d0e37
  22. 23 Jan, 2009 2 commits
    • Iustin Pop's avatar
      Relax the restrictions on temporary DRBD minors · 79b26a7a
      Iustin Pop authored
      Currently the restrictions are too harsh: there is a time interval
      between an instance gets a new disk and before it is added to the
      configuration in which the restriction is not met. We solve this by
      allowing temporary DRBD minors to match existing minors (for the same
      instance), such that parallel creations/minor allocations are OK.
      
      The change is done by moving the add of temporary minors to the
      minor map after the instance minors are computed, and only considering
      them as duplicate if the instance name doesn't match.
      
      Reviewed-by: ultrotter
      79b26a7a
    • Iustin Pop's avatar
      Introduce more configuration consistency checks · 4a89c54a
      Iustin Pop authored
      This patch enhances the duplicate DRBD minors checks (currently just a
      few) and adds automatic checks of configuration consistency at
      configuration file writing time.
      
      In order to do so and show meaningful error messages, the
      _UnlockedComputeDRBDMap function is changed to not raise errors in case
      of duplicates, but instead return both the minors map and the duplicate
      list, and its callers now raise the error. This allows the VerifyConfig
      function to return a complete list of duplicates.
      
      The new checks required some small updates to the unittests for the
      config module.
      
      Reviewed-by: ultrotter
      4a89c54a
  23. 21 Jan, 2009 2 commits
    • Iustin Pop's avatar
      Automatically release DRBD minors on success · 61cf6b5e
      Iustin Pop authored
      This patch converts the DRBD minors reservation protocol from explicit
      release to automatic release on the success paths. On the errors paths,
      it's still needed to manual release.
      
      The patch doesn't bring much by itself, but is needed for a future patch
      which enhances the automatic verification of configuration consistency.
      
      Reviewed-by: ultrotter
      61cf6b5e
    • Iustin Pop's avatar
      Change the instance status attribute to boolean · 0d68c45d
      Iustin Pop authored
      Due to historic reasons, the “should run or not” attribute of an
      instance was denoted by its “status” attribute having a string value of
      either ‘up’ or ‘down’. Checking this is in code was done via hardcoding
      of the strings.
      
      This was long done for a redo, and this patch changes this attribute to
      “admin_up” having a boolean value. The patch is in fact shorter than I
      expected, and passes burnin.
      
      The patch also fixes an error in BuildInstanceHookEnvByObject where the
      instance.os was passed as the status value.
      
      Reviewed-by: ultrotter
      0d68c45d
  24. 20 Jan, 2009 2 commits
    • Iustin Pop's avatar
      Fix adding of disks to an instance · 32388e6d
      Iustin Pop authored
      The ConfigWriter.AllocateDRBDMinor requires the instance name, not the
      instance object. The LUSetInstanceParms is passing wrongly the instance
      object, which can cause breakage.
      
      The patch also adds asserts to check for this mismatch in ConfigWriter.
      
      Reviewed-by: ultrotter
      32388e6d
    • Iustin Pop's avatar
      Make cluster-verify check the drbd minors space · 6d2e83d5
      Iustin Pop authored
      This patch adds support for verification of drbd minors space in cluster
      verify: minors which belong to running instances and should be online
      but are not, and minors which do not belong to any instace but are in
      use.
      
      The patch requires exposing some methods from bdev.DRBD8 and
      config.ConfigWriter which were until now private methods.
      
      Reviewed-by: ultrotter
      6d2e83d5
  25. 09 Jan, 2009 2 commits
    • Iustin Pop's avatar
      Add a new ssconf file with the ganeti version · 8a113c7a
      Iustin Pop authored
      The patch adds a new ssconf file containing the ganeti version.
      
      Reviewed-by: imsnah
      8a113c7a
    • Iustin Pop's avatar
      Fix gnt-os for offline nodes · 94a02bb5
      Iustin Pop authored
      We shouldn't query offline nodes in gnt-os. This patch adds an utility
      function to ConfigWriter that returns the names of online nodes and uses
      it in LUDiagnoseOS to query only the good nodes.
      
      Reviewed-by: imsnah
      94a02bb5
  26. 14 Dec, 2008 1 commit
  27. 11 Dec, 2008 1 commit
    • Iustin Pop's avatar
      Fix epydoc format warnings · c41eea6e
      Iustin Pop authored
      This patch should fix all outstanding epydoc parsing errors; as such, we
      switch epydoc into verbose mode so that any new errors will be visible.
      
      Reviewed-by: imsnah
      c41eea6e