1. 04 Jan, 2010 2 commits
  2. 28 Dec, 2009 1 commit
  3. 25 Nov, 2009 1 commit
  4. 06 Nov, 2009 1 commit
    • Iustin Pop's avatar
      Fix pylint 'E' (error) codes · 6c881c52
      Iustin Pop authored
      This patch adds some silences and tweaks the code slightly so that
      “pylint --rcfile pylintrc -e ganeti” doesn't give any errors.
      The biggest change is in jqueue.py, the move of _RequireOpenQueue out of
      the JobQueue class. Since that is actually a function and not a method
      (never used as such) this makes sense, and also silences two pylint
      Another real code change is in utils.py, where FieldSet.Matches will
      return None instead of False for failure; this still works with the way
      this class/method is used, and makes more sense (it resembles more
      closely the re.match return values).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
  5. 02 Nov, 2009 1 commit
  6. 29 Oct, 2009 1 commit
    • Michael Hanselmann's avatar
      http.auth: Add new function to verify passwords · bf9bd8dd
      Michael Hanselmann authored
      This new function supports two schemes for passwords:
      - Old-style cleartext passwords
      - Hashed passwords according to RFC2617 (H(A1))
      Schemes are differentiated by their prefix, a concept also
      used in OpenLDAP. Cleartext passwords can no longer start
      with an opening brace ("{") unless they're prefixed with
      "{cleartext}" (case insensitive).
      Currently there's no documentation for rapi_users at all.
      It'll be in a consecutive patch.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
  7. 25 Aug, 2009 1 commit
  8. 20 Aug, 2009 1 commit
  9. 07 Jul, 2009 2 commits
  10. 23 Jun, 2009 1 commit
    • Iustin Pop's avatar
      Fix HTTP server library handling of credentials · 81b59aaf
      Iustin Pop authored
      Currently the http library only checks credentials when authentication
      is required. This means that any credentials are accepted on the root
      resource, for example, which makes problems hard to diagnose - the
      user/pw works for all queries, until one tries to do a modification at
      which point fails.
      This patch changes the PreHandleRequest() function to not ignore
      credentials when passed, even if we don't require authentication. This
      makes the behavior of RAPI more predictable.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
  11. 20 Mar, 2009 1 commit
  12. 27 Feb, 2009 1 commit
    • Iustin Pop's avatar
      Fix some epydoc style issues · 5fcc718f
      Iustin Pop authored
      99% of the epydoc return tags are "@return:", but each of the modified files
      had one "@returns:" line. We fix this for consistency.
      Reviewed-by: imsnah
  13. 13 Feb, 2009 2 commits
    • Iustin Pop's avatar
      RAPI: format error messages as JSON · 1f8588f6
      Iustin Pop authored
      This patch changes the format of the HTTP error messages from text/html, which
      is hard to parse from RAPI clients, to JSON which can be automatically parsed.
      The error message is an object, which contains always three keys:
        - code, an integer with the error code
        - message, a short description
        - explain, holding (if available) a description of the error
      In order to implement this, there is a bit of change to the http server
      and executor classes. I've tested and the error handling still works
      (but less optimal, no error message) in case the error formatting itself
      raises an exception.
      Reviewed-by: imsnah
    • Iustin Pop's avatar
      Make RAPI return 502/504 errors for luxi errors · 77e1d753
      Iustin Pop authored
      This changes the RAPI error codes for luxi errors; a timeout error is
      now reported properly as 504, while any other luxi error is reported as
      It would be good to convert even more errors into proper return codes in
      the future.
      Reviewed-by: imsnah
  14. 04 Feb, 2009 1 commit
    • Iustin Pop's avatar
      rapi: fix authentication and queries · 85414b69
      Iustin Pop authored
      For queries, we don't want to require authentication. We fix this by adding an
      override GetAuthRealm in the rapi daemon.
      We also fix a method name.
      Reviewed-by: imsnah
  15. 15 Jan, 2009 2 commits
    • Iustin Pop's avatar
      Some docstring updates · 25e7b43f
      Iustin Pop authored
      This patch rewraps some comments to shorter lengths, changes
      double-quotes to single-quotes inside triple-quoted docstrings for
      better editor handling.
      It also fixes some epydoc errors, namely invalid crossreferences (after
      method rename), documentation for inexistent (removed) parameters, etc.
      Reviewed-by: ultrotter
    • Iustin Pop's avatar
      ganeti-noded: reduce log noise · 14d57a8b
      Iustin Pop authored
      The source port/addr is currently logged three times for each
      connection, and this is unnecessary. We change two log entries to debug,
      since they are useful for precise timing, and we keep only one at INFO
      Reviewed-by: imsnah
  16. 06 Jan, 2009 1 commit
  17. 19 Dec, 2008 4 commits
  18. 18 Dec, 2008 5 commits
  19. 17 Dec, 2008 1 commit
  20. 15 Dec, 2008 4 commits
  21. 14 Dec, 2008 2 commits
  22. 12 Dec, 2008 2 commits
  23. 11 Dec, 2008 1 commit
    • Iustin Pop's avatar
      Fix epydoc format warnings · c41eea6e
      Iustin Pop authored
      This patch should fix all outstanding epydoc parsing errors; as such, we
      switch epydoc into verbose mode so that any new errors will be visible.
      Reviewed-by: imsnah
  24. 10 Dec, 2008 1 commit