1. 03 Sep, 2012 1 commit
    • Iustin Pop's avatar
      Fix warnings/errors with newer pylint · 8ad0da1e
      Iustin Pop authored
      
      
      To help developing Ganeti on newer distributions, let's try to fix
      pylint warnings/errors. I'm using pylint from current Debian wheezy:
      pylint 0.25.1, astng 0.23.1, common 0.58.0, and we have 3 things that
      needs fixing.
      
      First, a really wide "except", with the silencing in the wrong
      place. I'm not sure why this doesn't have "except Exception", so let's
      add it. However, pylint still complains about "Catching too general
      exception", even though we do want to catch both system and our
      exception, so let's add a silence for W0703. It's true that we
      shouldn't catch KeyboardInterrupt and friends, but that should be
      cleaned up on the master branch.
      
      Second, pylint complains about "redefining name builtin tuple",
      because we do some pattern matching in the except blocks in
      netutils. This seems to be a false positive, but let's clean the code
      around this.
      
      And finally, type inference again goes bad, so let's silence E1103
      with its "boolean doesn't have 'get' method".
      
      After this, I can run "make lint", and by extension "make
      commit-check" on Debian Wheezy, yay! We might be able to bump our
      required pylint versions to something not ancient…
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      8ad0da1e
  2. 15 Jun, 2012 1 commit
  3. 07 Jun, 2012 1 commit
  4. 05 Jun, 2012 1 commit
  5. 10 May, 2012 1 commit
  6. 04 May, 2012 1 commit
  7. 23 Apr, 2012 1 commit
  8. 30 Aug, 2011 1 commit
  9. 25 Jul, 2011 1 commit
  10. 12 Jan, 2011 1 commit
    • Iustin Pop's avatar
      Run pylint over QA code too · 3582eef6
      Iustin Pop authored
      
      
      Right now, the QA code is not covered by pylint, and this shows at
      least one low-impact bug.
      
      This patch does the necessary changes to make QA pylint-clean, and the
      changes the makefile to run pylint for it.
      
      Notable changes:
      
      - qa_utils.GenericQueryTest: randfields was not used at all, and my
        belief is that it was indented to be used in order not to modify the
        input list; so I replaced randfields with fields, so we only shuffle
        the our local copy
      - qa_node.TestOutOfBand was using it's own copy of AcquireNode(), so I
        replaced it with the existing version
      - qa_os: was using 'dir' in a couple of places, replaced with dirname
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      3582eef6
  11. 30 Nov, 2010 1 commit
    • Iustin Pop's avatar
      Further cleanups on QA · 7d88f255
      Iustin Pop authored
      
      
      This is more of an RFC. The patch attempts to address two issues:
      
      - running conditional tests is ugly right now
      - we don't know what tests we skipped
      
      By using the new RunTestIf, we solve both. But a significant number of
      test decisions are more complex than just “is test enabled”, so those
      remain to be run via RunTest, which means we don't get logging of when
      they're not run. Hence the logging is not complete… Sugesstions on how
      to solve it are welcome.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      7d88f255
  12. 05 Oct, 2010 2 commits
  13. 01 Dec, 2008 1 commit
  14. 18 Aug, 2008 1 commit
    • Michael Hanselmann's avatar
      QA: Convert configuration from YAML to JSON · 8c4a9a74
      Michael Hanselmann authored
      We no longer use YAML in Ganeti at all. This patch converts the QA
      configuration from YAML to JSON. JSON doesn't support comments and
      I had to use a hack with fields starting with '#'.
      
      Reviewed-by: ultrotter
      8c4a9a74
  15. 25 Mar, 2008 1 commit
    • Iustin Pop's avatar
      Remove the option to create md/drbd7 instances · f9193417
      Iustin Pop authored
      This patch removes the options that allow to create local_raid1 or
      remote_raid1 instances. It also modifies the documentation and removes
      these disk templates from burnin and from qa.
      
      Reviewed-by: imsnah
      f9193417
  16. 14 Feb, 2008 1 commit
  17. 21 Nov, 2007 1 commit
  18. 12 Oct, 2007 1 commit
  19. 13 Sep, 2007 1 commit