Skip to content

GitLab

Switch branch/tag
  1. 11 Jun, 2012 1 commit
    • Iustin Pop's avatar
      Enable hlint in lint and reorganise this target · 6e4c8f68
      Iustin Pop authored 
      

Currently, the lint target does a sequential: pep8, pylint, pylint on
the QA sources. hlint is run only when explicitly requested.

This patch reorganises the lint target by:

- splitting the current lint target into separate pylint (slow),
  pylint-qa (fast), pep8 (fast) targets
- making lint itself depend on the above plus hlint
- both pep8 and hlint are optional, based on whether the said binaries
  were detected at configure time

make -j is slightly faster after this patch (1m18s → 1m7s).
Signed-off-by: default avatarIustin Pop <iustin@google.com>
Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      6e4c8f68
  3. 01 Jun, 2012 1 commit
  5. 31 May, 2012 1 commit
  7. 23 May, 2012 1 commit
  9. 11 May, 2012 1 commit
  11. 11 Apr, 2012 2 commits
  13. 27 Mar, 2012 1 commit
  15. 23 Mar, 2012 2 commits
    • Iustin Pop's avatar
      Enable selection between Python and Haskell confd · 73b0fa69
      Iustin Pop authored 
      

This patch changes configure.ac Makefile.am so that the user can pass:

- --disable-confd (or --enable-confd=no) to disable it completely
- --enable-confd=yes or --enable-confd=python to select the
  traditional implementation (this is the default setting)
- --enable-confd=haskell to select hconfd

The only "not nice" thing is that I've chosen to keep the
hconfd.hs/hconfd name, and we rename it after install via an
install-exec-hook. The other choice is possible too (to rename the
source file/binary).

One additional note is that if we select haskell, the _rule_ for
creating daemons/ganeti-confd dissapears; whereas if we select python,
the rule for htools/hconfd still exists (one can build it explicitly),
it just is not installed. This is due to the different way in which
the rules are declared.
Signed-off-by: default avatarIustin Pop <iustin@google.com>
Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      73b0fa69
    • Iustin Pop's avatar
      Fix qemu-img configure.ac check · acf70442
      Iustin Pop authored 
      By accident, commit a002ed79

 introduced the qemu-img checks in the
htools block. I found this also by mistake while investigating
another issue :)
Signed-off-by: default avatarIustin Pop <iustin@google.com>
Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      acf70442
  17. 22 Mar, 2012 1 commit
  19. 21 Mar, 2012 1 commit
  21. 19 Jan, 2012 1 commit
  23. 09 Jan, 2012 1 commit
  25. 22 Dec, 2011 1 commit
  27. 06 Dec, 2011 1 commit
    • Andrea Spadaccini's avatar
      Add DRBD barriers disk parameters · 8a69b3a8
      Andrea Spadaccini authored 
      

Add the disk-barriers and meta-barriers parameters described in the
design doc.

constants.py:
* add the needed LD and DT-level parameters, use the defaults provided
  at ./configure time;
* add constants representing which barriers should be disabled and the
  set of valid options.

lib/bdev.py:
* factor the barriers handling code to a class method, for testing
  purposes;
* implement the more granular version checking logic;
* use the LD level parameters;
* add stricter check on DRBD version (8.0, 8.2 or 8.3), as we do not
  support 8.4 yet.

lib/cmdlib.py:
* translate DT level parameters to LD level ones.

configure.ac, Makefile.am:
* set both disk and meta barriers parameters depending on the value of
  --enable-drbd-barriers.

test/ganeti.bdev_unittest.py:
* unit tests for the code that sets DRBD barrier parameters depending on
  the version.

doc/design-resource-model.rst:
* reword the description of meta-barriers;
* change all disk parameters names to use dashes instead of underscores.
Signed-off-by: default avatarAndrea Spadaccini <spadaccio@google.com>
Reviewed-by: default avatarIustin Pop <iustin@google.com>
      8a69b3a8
  29. 02 Dec, 2011 1 commit
  31. 17 Nov, 2011 1 commit
  33. 27 Oct, 2011 2 commits
  35. 26 Oct, 2011 1 commit
  37. 20 Oct, 2011 2 commits
  39. 18 Oct, 2011 1 commit
  41. 04 Oct, 2011 1 commit
  43. 15 Sep, 2011 2 commits
  45. 31 Aug, 2011 1 commit
  47. 26 Aug, 2011 1 commit
  49. 23 Aug, 2011 1 commit
  51. 19 Aug, 2011 1 commit
  53. 08 Aug, 2011 1 commit
  55. 05 Aug, 2011 2 commits
  57. 19 Jul, 2011 1 commit
  59. 28 Jun, 2011 2 commits
    • Iustin Pop's avatar
      Fix htools, QuickCheck library detection and tests · e5f6768c
      Iustin Pop authored 
      

Just saw this while testing the migration to QuickCheck v2: while
configure.ac detects that QuickCheck-2.x is not available, the test in
Makefile.am was against WANT_HTOOLS (overall htools compilation), not
on a more-specific WANT_HTOOLSTESTS.
Signed-off-by: default avatarIustin Pop <iustin@google.com>
Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      e5f6768c
    • Iustin Pop's avatar
      htools: Switch to QuickCheck 2.x · 8e4f6d56
      Iustin Pop authored 
      

Since current distros don't package anymore QuickCheck 1.x, let's move
to 2.x.

This requires also a few changes to the code:

- Test.QuickCheck.Batch doesn't exist anymore, so we need to write some
  scaffolding code to replace it
- the way test sizes are generated has changed, and we need to restrict
  (in some tests) the cluster size, as our code is not yet ready for
  hundreds of thousands of nodes in a cluster and we run out of stack
  (which could be a bug somewhere by itself, needs investigation)
- at least with GHC 7, floating point errors make a perfect cluster
  score even bigger, so we need to bump up the max. rounding error
  allowed
Signed-off-by: default avatarIustin Pop <iustin@google.com>
Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      8e4f6d56
  61. 24 Jun, 2011 1 commit
  63. 24 May, 2011 1 commit
  65. 12 May, 2011 1 commit