1. 13 Jan, 2011 1 commit
    • Iustin Pop's avatar
      Fix growing of DRBD disks · 6d33a6eb
      Iustin Pop authored
      Patch 03941a26
      
       made disk growth VG-aware, but the code has a bug: it
      only works for LD_LV disks, and not LD_DRBD. To fix it, we add a
      generic function to compute the per-VG growth requirements, and switch
      to using that instead of manual build.
      
      Furthermore, since the function _CheckNodesFreeDiskPerVG always takes
      its input from this new function or _ComputeDiskSizePerVG, we change
      the latter to always return a dict (possibly empty), instead of either
      a dict or None. This makes the types more consistent.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      6d33a6eb
  2. 11 Jan, 2011 1 commit
  3. 07 Jan, 2011 1 commit
  4. 14 Dec, 2010 1 commit
  5. 13 Dec, 2010 3 commits
  6. 08 Dec, 2010 2 commits
  7. 06 Dec, 2010 1 commit
  8. 02 Dec, 2010 1 commit
    • Dmitry Chernyak's avatar
      Make rpc.call_lv_list() VG-aware · 84d7e26b
      Dmitry Chernyak authored
      
      
      Changes to backend.GetVolumeList():
      - now accepts a list of VGs instead of one VG
      - returns LV names in the form "vg_name/lv_name"
      
      Corresponding changes are done in: VerifyDisks, VerifyNode,
      LUCreateInstance (for both disk creation and adoption cases)
      
      Now the syntax
      "gnt-instance add ... --disk N:adopt=LV_NAME,vg=VG_NAME"
      as was described earlier in the man page works.
      Signed-off-by: default avatarDmitry Chernyak <dmi.chernyak@gmail.com>
      [iustin@google.com: QA changes for reserved LVs, style fixes and a few
       extra error checks, reviewed by hansmi/rn]
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      84d7e26b
  9. 29 Nov, 2010 2 commits
  10. 22 Nov, 2010 1 commit
  11. 27 Oct, 2010 1 commit
  12. 26 Oct, 2010 1 commit
    • Iustin Pop's avatar
      Rename node.nodegroup to node.group · f936c153
      Iustin Pop authored
      
      
      In the context of a node, its group has (at least today) only one
      meaning, that is the node's node group. As such, we rename
      node.nodegroup to just node.group.
      
      Note: if we want to keep node in there, it should be at least
      node_group, for consistency with the other node attributes.
      
      Similarly, we rename the OpAddNode nodegroup attribute to group.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      f936c153
  13. 12 Oct, 2010 1 commit
  14. 05 Oct, 2010 1 commit
  15. 30 Sep, 2010 2 commits
    • Iustin Pop's avatar
      Add two new cluster settings · 546b1111
      Iustin Pop authored
      
      
      The new variables are:
      
      - a list of hidden OSes, that should not be displayed to the users in
        interactive selection (e.g. reinstall); however, if they are selected, they
        can be used
      - a list of OSes that should be hidden and blocked from install-time selection
      
      The filtering will apply at pure OS name level, not OS+variant level.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      546b1111
    • Iustin Pop's avatar
      Abstract OS name/variant functions · 870dc44c
      Iustin Pop authored
      
      
      Currently, the computation of the 'pure' name or the variant is
      hardcoded and spread around the functions that need it. This is not
      nice, and in the future we'd spread it even more with more usage of
      variants/pure os names.
      
      This patch abstracts these functions into the OS class, and then
      replaces the hardcoded uses with the new functions.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      870dc44c
  16. 15 Sep, 2010 1 commit
  17. 14 Sep, 2010 4 commits
  18. 06 Sep, 2010 1 commit
  19. 19 Aug, 2010 1 commit
  20. 26 Jul, 2010 1 commit
  21. 08 Jul, 2010 1 commit
  22. 06 Jul, 2010 3 commits
  23. 28 Jun, 2010 1 commit
  24. 23 Jun, 2010 2 commits
  25. 17 Jun, 2010 1 commit
  26. 14 Jun, 2010 3 commits
    • Iustin Pop's avatar
      Remove a TODO · 592e04bd
      Iustin Pop authored
      
      
      Since OS objects are not stored in the configuration, we cannot put
      os_hvp there, therefore the TODO is obsolete…
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      592e04bd
    • Iustin Pop's avatar
      Add cluster.SimpleFill*() functions · 73e0328b
      Iustin Pop authored
      
      
      Currently, the existing cluster.Fill* functions take as argument an
      instance. This means that in any case where we don't have an actual
      instance object, we have to resort to calling the low-level
      objects.FillDict function.
      
      This is bad for two reasons:
      - we have to know of, and we hardcode, the cluster object internals
        (e.g. that the nicparams are stored in a dict indexed by group)
      - which can result in subtle bugs, if the underlying storage mechanisms
        change
      
      This patch adds a lower-level implementation SimpleFillHV for FillHV and
      SimpleFillBE for FillBE, and adds a completely new SimpleFillNIC (all
      use cases until now hardcoded cluster.nicparams[constant.PP_DEFAULT]
      directly); it then uses these new functions in cmdlib.py.
      
      A side effect is that _CheckNicsBridgesExist loses the 'profile'
      parameter, which was unused. If it's needed, we should add it later via
      a proper profile parameter to SimpleFillNIC.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      73e0328b
    • Michael Hanselmann's avatar
  27. 08 Jun, 2010 1 commit